[PATCH v2 3/7] clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup()

Haoxiang Li posted 7 patches 2 weeks, 6 days ago
[PATCH v2 3/7] clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup()
Posted by Haoxiang Li 2 weeks, 6 days ago
In clkgen_c32_pll_setup(), `clk` is used for two distint variables' name.
This patch rename the later `clk` to `odf_clk`.
The rename is in preparation for cleaning up some memory leaks.

Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
 drivers/clk/st/clkgen-pll.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 24b9b66a83e1..566eb7e8a73c 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -797,7 +797,7 @@ static void __init clkgen_c32_pll_setup(struct device_node *np,
 		goto err;
 
 	for (odf = 0; odf < num_odfs; odf++) {
-		struct clk *clk;
+		struct clk *odf_clk;
 		const char *clk_name;
 		unsigned long odf_flags = 0;
 
@@ -813,13 +813,13 @@ static void __init clkgen_c32_pll_setup(struct device_node *np,
 			of_clk_detect_critical(np, odf, &odf_flags);
 		}
 
-		clk = clkgen_odf_register(pll_name, pll_base, datac->data,
+		odf_clk = clkgen_odf_register(pll_name, pll_base, datac->data,
 				odf_flags, odf, &clkgena_c32_odf_lock,
 				clk_name);
-		if (IS_ERR(clk))
+		if (IS_ERR(odf_clk))
 			goto err;
 
-		clk_data->clks[odf] = clk;
+		clk_data->clks[odf] = odf_clk;
 	}
 
 	of_clk_add_provider(np, of_clk_src_onecell_get, clk_data);
-- 
2.25.1
Re: [PATCH v2 3/7] clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup()
Posted by Brian Masney 2 weeks, 4 days ago
On Wed, Jan 21, 2026 at 09:22:19AM +0800, Haoxiang Li wrote:
> In clkgen_c32_pll_setup(), `clk` is used for two distint variables' name.
> This patch rename the later `clk` to `odf_clk`.
> The rename is in preparation for cleaning up some memory leaks.
> 
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>

Reviewed-by: Brian Masney <bmasney@redhat.com>
Re: [PATCH v2 3/7] clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup()
Posted by Markus Elfring 2 weeks, 5 days ago
> In clkgen_c32_pll_setup(), `clk` is used for two distint variables' name.
> This patch rename …

* Did anything hinder you to avoid typos in such a change description?

* See also once more:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n94


Regards,
Markus