[PATCH v5 2/2] media: i2c: imx412: Extend the power-on waiting time

Wenmeng Liu posted 2 patches 2 weeks, 5 days ago
There is a newer version of this series
[PATCH v5 2/2] media: i2c: imx412: Extend the power-on waiting time
Posted by Wenmeng Liu 2 weeks, 5 days ago
The Arducam IMX577 module requires a longer reset time than the 1000µs
configured in the current driver. Increase the wait time after power-on
to ensure proper initialization.

Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
 drivers/media/i2c/imx412.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
index aa63dfc349181bf9c180ffd566b0317d05b410c1..b1c201b4c7d008aa70ac84205e4de119e776047b 100644
--- a/drivers/media/i2c/imx412.c
+++ b/drivers/media/i2c/imx412.c
@@ -1037,7 +1037,7 @@ static int imx412_power_on(struct device *dev)
 		goto error_reset;
 	}
 
-	usleep_range(1000, 1200);
+	usleep_range(10000, 12000);
 
 	return 0;
 

-- 
2.34.1

Re: [PATCH v5 2/2] media: i2c: imx412: Extend the power-on waiting time
Posted by Sakari Ailus 2 weeks, 5 days ago
Hi Wenmeng,

On Wed, Jan 21, 2026 at 05:12:15PM +0800, Wenmeng Liu wrote:
> The Arducam IMX577 module requires a longer reset time than the 1000µs
> configured in the current driver. Increase the wait time after power-on
> to ensure proper initialization.
> 
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> ---
>  drivers/media/i2c/imx412.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
> index aa63dfc349181bf9c180ffd566b0317d05b410c1..b1c201b4c7d008aa70ac84205e4de119e776047b 100644
> --- a/drivers/media/i2c/imx412.c
> +++ b/drivers/media/i2c/imx412.c
> @@ -1037,7 +1037,7 @@ static int imx412_power_on(struct device *dev)
>  		goto error_reset;
>  	}
>  

Could you please add the comment why this was being done? It's not enough
to have this in the commit message.

> -	usleep_range(1000, 1200);
> +	usleep_range(10000, 12000);
>  
>  	return 0;
>  
> 

-- 
Regards,

Sakari Ailus
Re: [PATCH v5 2/2] media: i2c: imx412: Extend the power-on waiting time
Posted by Wenmeng Liu 2 weeks, 5 days ago
Hi Sakari.

On 1/21/2026 5:54 PM, Sakari Ailus wrote:
> Hi Wenmeng,
> 
> On Wed, Jan 21, 2026 at 05:12:15PM +0800, Wenmeng Liu wrote:
>> The Arducam IMX577 module requires a longer reset time than the 1000µs
>> configured in the current driver. Increase the wait time after power-on
>> to ensure proper initialization.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>> ---
>>   drivers/media/i2c/imx412.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
>> index aa63dfc349181bf9c180ffd566b0317d05b410c1..b1c201b4c7d008aa70ac84205e4de119e776047b 100644
>> --- a/drivers/media/i2c/imx412.c
>> +++ b/drivers/media/i2c/imx412.c
>> @@ -1037,7 +1037,7 @@ static int imx412_power_on(struct device *dev)
>>   		goto error_reset;
>>   	}
>>   
> 
> Could you please add the comment why this was being done? It's not enough
> to have this in the commit message.
Sure, will do.

Thanks,
Wenmeng