On Tue, 20 Jan 2026 12:59:17 +0100, Khristine Andreea Barbulescu
<khristineandreea.barbulescu@oss.nxp.com> said:
> From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
>
> Switch from "devm_pinctrl_register" to "devm_pinctrl_register_and_init"
> and "pinctrl_enable" since this is the recommended way.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
> ---
> drivers/pinctrl/nxp/pinctrl-s32cc.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> index a98f8e7c2768..4767916dbcab 100644
> --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> @@ -974,10 +974,10 @@ int s32_pinctrl_probe(struct platform_device *pdev,
> return dev_err_probe(&pdev->dev, ret,
> "Fail to probe dt properties\n");
>
> - ipctl->pctl = devm_pinctrl_register(&pdev->dev, s32_pinctrl_desc,
> - ipctl);
> - if (IS_ERR(ipctl->pctl))
> - return dev_err_probe(&pdev->dev, PTR_ERR(ipctl->pctl),
> + ret = devm_pinctrl_register_and_init(&pdev->dev, s32_pinctrl_desc,
> + ipctl, &ipctl->pctl);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> "Could not register s32 pinctrl driver\n");
>
> #ifdef CONFIG_PM_SLEEP
> @@ -990,7 +990,12 @@ int s32_pinctrl_probe(struct platform_device *pdev,
> return -ENOMEM;
> #endif
>
> - dev_info(&pdev->dev, "initialized s32 pinctrl driver\n");
> + ret = pinctrl_enable(ipctl->pctl);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> + "Failed to enable pinctrl\n");
> +
> + dev_info(&pdev->dev, "Initialized S32 pinctrl driver\n");
>
> return 0;
> }
> --
> 2.50.1
>
>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>