pinctrl: tigerlake: Add Alder Lake-P documentation

[PATCH] pinctrl: tigerlake: Add Alder Lake-P documentation

Posted by Raag Jadav 2 weeks, 3 days ago

Intel Alder Lake-P PCH reuses pinctrl IP from Tiger Lake-LP. Add user
friendly documentation for it.

Cc: stable@vger.kernel.org
Fixes: 0e793a4e2834 ("pinctrl: tigerlake: Add Alder Lake-P ACPI ID")
Reported-by: Guido Trentalancia <guido@trentalancia.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220056
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/intel/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
index e4dc9ba899bd..045651fde31f 100644
--- a/drivers/pinctrl/intel/Kconfig
+++ b/drivers/pinctrl/intel/Kconfig
@@ -160,7 +160,9 @@ config PINCTRL_TIGERLAKE
 	select PINCTRL_INTEL
 	help
 	  This pinctrl driver provides an interface that allows configuring
-	  of Intel Tiger Lake PCH pins and using them as GPIOs.
+	  PCH pins of the following platforms and using them as GPIOs.
+	  - Tiger Lake
+	  - Alder Lake-P
 
 source "drivers/pinctrl/intel/Kconfig.tng"
 endmenu
-- 
2.43.0

Re: [PATCH] pinctrl: tigerlake: Add Alder Lake-P documentation

Posted by Andy Shevchenko 2 weeks, 3 days ago

On Tue, Jan 20, 2026 at 04:30:42PM +0530, Raag Jadav wrote:
> Intel Alder Lake-P PCH reuses pinctrl IP from Tiger Lake-LP. Add user
> friendly documentation for it.

Thanks for doing this!

Side note, though: this is not the only driver suffering of the similar issue.
Can you address them all?

...

>  	select PINCTRL_INTEL
>  	help
>  	  This pinctrl driver provides an interface that allows configuring
> -	  of Intel Tiger Lake PCH pins and using them as GPIOs.
> +	  PCH pins of the following platforms and using them as GPIOs.
> +	  - Tiger Lake

We also have letter suffix for the above. Does this driver covers _all_ Tiger
Lake modifications?

If so, I would do

	  - Tiger Lake (all modifications)

> +	  - Alder Lake-P

I can tweak this when applying if confirmed, otherwise we would need
a revisit v2.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] pinctrl: tigerlake: Add Alder Lake-P documentation

Posted by Guido Trentalancia 2 weeks, 3 days ago

Someone erroneously marked the bug as CLOSED INVALID, while only the
proposed resolution was INVALID and not the bug itself.

This patch solves the issue because it informs the user on the correct
driver to choose for Alder Lake-P.

Acked-by: Guido Trentalancia <guido@trentalancia.com>

On Tue, 20/01/2026 at 16.30 +0530, Raag Jadav wrote:
> Intel Alder Lake-P PCH reuses pinctrl IP from Tiger Lake-LP. Add user
> friendly documentation for it.
> 
> Cc: stable@vger.kernel.org
> Fixes: 0e793a4e2834 ("pinctrl: tigerlake: Add Alder Lake-P ACPI ID")
> Reported-by: Guido Trentalancia <guido@trentalancia.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220056
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/pinctrl/intel/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/Kconfig
> b/drivers/pinctrl/intel/Kconfig
> index e4dc9ba899bd..045651fde31f 100644
> --- a/drivers/pinctrl/intel/Kconfig
> +++ b/drivers/pinctrl/intel/Kconfig
> @@ -160,7 +160,9 @@ config PINCTRL_TIGERLAKE
>  	select PINCTRL_INTEL
>  	help
>  	  This pinctrl driver provides an interface that allows
> configuring
> -	  of Intel Tiger Lake PCH pins and using them as GPIOs.
> +	  PCH pins of the following platforms and using them as
> GPIOs.
> +	  - Tiger Lake
> +	  - Alder Lake-P
>  
>  source "drivers/pinctrl/intel/Kconfig.tng"
>  endmenu

Re: [PATCH] pinctrl: tigerlake: Add Alder Lake-P documentation

Posted by Andy Shevchenko 2 weeks, 3 days ago

On Tue, Jan 20, 2026 at 01:52:36PM +0100, Guido Trentalancia wrote:
> Someone erroneously marked the bug as CLOSED INVALID, while only the
> proposed resolution was INVALID and not the bug itself.
> 
> This patch solves the issue because it informs the user on the correct
> driver to choose for Alder Lake-P.

Yes, I was that person and I asked Raag to help with it.
Thanks, Raag!

Now we can close it again with PATCH_AVAILABLE.

> Acked-by: Guido Trentalancia <guido@trentalancia.com>

Thanks for confirming!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] pinctrl: tigerlake: Add Alder Lake-P documentation

Posted by Mika Westerberg 2 weeks, 3 days ago

On Tue, Jan 20, 2026 at 04:30:42PM +0530, Raag Jadav wrote:
> Intel Alder Lake-P PCH reuses pinctrl IP from Tiger Lake-LP. Add user
> friendly documentation for it.
> 
> Cc: stable@vger.kernel.org
> Fixes: 0e793a4e2834 ("pinctrl: tigerlake: Add Alder Lake-P ACPI ID")
> Reported-by: Guido Trentalancia <guido@trentalancia.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220056
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>