[PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride

Wei Zhang posted 1 patch 2 weeks, 4 days ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++
1 file changed, 105 insertions(+)
[PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Posted by Wei Zhang 2 weeks, 4 days ago
Enable WLAN on qcs8300-ride by adding a node for the PMU module
of the WCN6855 and assigning its LDO power outputs to the existing
WiFi module.

On the qcs8300-ride platform, the corresponding firmware and BDF
are QCA6698AQ instead of WCN6855, which have been added in the
20250211 release.

Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
---
This patch depends on:
- PCIe
https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/

Changes in v8:
- Reordered regulator nodes to maintain alphabetical consistency (Dmitry)
- Place wifi@0 node under existing pcieport0 label
- Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/

Changes in v7:
- Align regulator node names to match the existing naming style in the dts (Dmitry)
- Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/

Changes in v6:
- Rebase patches
- Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad)
- Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/

Changes in v5:
- Rebase patches
- Flip the order of property-n and property-names (Konrad)
- Flip the order of bias and output property (Konrad)
- Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/

Changes in v4:
- Rename the symbol pcieport0 to pcie0_port0 (Konrad)
- Adjust the property order in node pcie0_port0 (Konrad)
- Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry)
- Specify the calibration data using the correct variant (Dmitry)
- Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/

Changes in v3:
- Complete the nodes property definitions according to DTS binding requirements (Bjorn)
- Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/

Changes in v2:
- Rename the nodes name according to DTS coding style (Konrad & Krzysztof)
- Provide regulator-min/max-microvolt to the regulators (Konrad)
- Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 68691f7b5f94..864b32503d29 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -24,6 +24,26 @@ chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	vreg_conn_1p8: regulator-conn-1p8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_conn_1p8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		startup-delay-us = <4000>;
+		enable-active-high;
+		gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
+	};
+
+	vreg_conn_pa: regulator-conn-pa {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_conn_pa";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		startup-delay-us = <4000>;
+		enable-active-high;
+		gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
+	};
+
 	regulator-usb2-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "USB2_VBUS";
@@ -33,6 +53,68 @@ regulator-usb2-vbus {
 		enable-active-high;
 		regulator-always-on;
 	};
+
+	wcn6855-pmu {
+		compatible = "qcom,wcn6855-pmu";
+
+		pinctrl-0 = <&wlan_en_state>;
+		pinctrl-names = "default";
+
+		vddio-supply = <&vreg_conn_pa>;
+		vddaon-supply = <&vreg_conn_1p8>;
+		vddpmu-supply = <&vreg_conn_pa>;
+		vddpmumx-supply = <&vreg_conn_1p8>;
+		vddpmucx-supply = <&vreg_conn_pa>;
+		vddrfa0p95-supply = <&vreg_conn_1p8>;
+		vddrfa1p3-supply = <&vreg_conn_pa>;
+		vddrfa1p9-supply = <&vreg_conn_1p8>;
+		vddpcie1p3-supply = <&vreg_conn_pa>;
+		vddpcie1p9-supply = <&vreg_conn_1p8>;
+
+		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
+
+		regulators {
+			vreg_pmu_rfa_cmn: ldo0 {
+				regulator-name = "vreg_pmu_rfa_cmn";
+			};
+
+			vreg_pmu_aon_0p59: ldo1 {
+				regulator-name = "vreg_pmu_aon_0p59";
+			};
+
+			vreg_pmu_wlcx_0p8: ldo2 {
+				regulator-name = "vreg_pmu_wlcx_0p8";
+			};
+
+			vreg_pmu_wlmx_0p85: ldo3 {
+				regulator-name = "vreg_pmu_wlmx_0p85";
+			};
+
+			vreg_pmu_btcmx_0p85: ldo4 {
+				regulator-name = "vreg_pmu_btcmx_0p85";
+			};
+
+			vreg_pmu_rfa_0p8: ldo5 {
+				regulator-name = "vreg_pmu_rfa_0p8";
+			};
+
+			vreg_pmu_rfa_1p2: ldo6 {
+				regulator-name = "vreg_pmu_rfa_1p2";
+			};
+
+			vreg_pmu_rfa_1p7: ldo7 {
+				regulator-name = "vreg_pmu_rfa_1p7";
+			};
+
+			vreg_pmu_pcie_0p9: ldo8 {
+				regulator-name = "vreg_pmu_pcie_0p9";
+			};
+
+			vreg_pmu_pcie_1p8: ldo9 {
+				regulator-name = "vreg_pmu_pcie_1p8";
+			};
+		};
+	};
 };
 
 &apps_rsc {
@@ -327,6 +409,23 @@ &pcie0 {
 &pcieport0 {
 	reset-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
 	wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;
+
+	wifi@0 {
+		compatible = "pci17cb,1103";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+		vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+		vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+
+		qcom,calibration-variant = "QC_QCS8300_Ride";
+	};
 };
 
 &pcie0_phy {
@@ -461,6 +560,12 @@ perst-pins {
 			bias-pull-down;
 		};
 	};
+
+	wlan_en_state: wlan-en-state {
+		pins = "gpio54";
+		function = "gpio";
+		bias-pull-up;
+	};
 };
 
 &uart7 {

base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
prerequisite-patch-id: 0e8aad7b8514142fb33c17829386f17c3a55127a
prerequisite-patch-id: e641f09d4139ac77c34757bd08af2db746de3963
prerequisite-patch-id: 4d16e87cf6213d6e25b2c40e2753d4e629778d53
prerequisite-patch-id: 40187dae2c9518a10866104b9fcd5a481ac67d51
prerequisite-patch-id: dd3bdf2aebda74f3603aff24a2c9aaa7f4fd6763
-- 
2.34.1
Re: [PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Posted by Dmitry Baryshkov 2 weeks, 4 days ago
On Mon, Jan 19, 2026 at 11:06:49PM -0800, Wei Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
> 
> On the qcs8300-ride platform, the corresponding firmware and BDF
> are QCA6698AQ instead of WCN6855, which have been added in the
> 20250211 release.
> 
> Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
> ---
> This patch depends on:
> - PCIe
> https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/
> 
> Changes in v8:
> - Reordered regulator nodes to maintain alphabetical consistency (Dmitry)
> - Place wifi@0 node under existing pcieport0 label
> - Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/
> 
> Changes in v7:
> - Align regulator node names to match the existing naming style in the dts (Dmitry)
> - Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/
> 
> Changes in v6:
> - Rebase patches
> - Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad)
> - Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
> 
> Changes in v5:
> - Rebase patches
> - Flip the order of property-n and property-names (Konrad)
> - Flip the order of bias and output property (Konrad)
> - Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/
> 
> Changes in v4:
> - Rename the symbol pcieport0 to pcie0_port0 (Konrad)
> - Adjust the property order in node pcie0_port0 (Konrad)
> - Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry)
> - Specify the calibration data using the correct variant (Dmitry)
> - Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/
> 
> Changes in v3:
> - Complete the nodes property definitions according to DTS binding requirements (Bjorn)
> - Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/
> 
> Changes in v2:
> - Rename the nodes name according to DTS coding style (Konrad & Krzysztof)
> - Provide regulator-min/max-microvolt to the regulators (Konrad)
> - Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++
>  1 file changed, 105 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 68691f7b5f94..864b32503d29 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -24,6 +24,26 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	vreg_conn_1p8: regulator-conn-1p8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg_conn_1p8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		startup-delay-us = <4000>;
> +		enable-active-high;
> +		gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	vreg_conn_pa: regulator-conn-pa {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg_conn_pa";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		startup-delay-us = <4000>;
> +		enable-active-high;
> +		gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
> +	};
> +
>  	regulator-usb2-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "USB2_VBUS";
> @@ -33,6 +53,68 @@ regulator-usb2-vbus {
>  		enable-active-high;
>  		regulator-always-on;
>  	};
> +
> +	wcn6855-pmu {
> +		compatible = "qcom,wcn6855-pmu";
> +
> +		pinctrl-0 = <&wlan_en_state>;
> +		pinctrl-names = "default";
> +
> +		vddio-supply = <&vreg_conn_pa>;
> +		vddaon-supply = <&vreg_conn_1p8>;
> +		vddpmu-supply = <&vreg_conn_pa>;
> +		vddpmumx-supply = <&vreg_conn_1p8>;
> +		vddpmucx-supply = <&vreg_conn_pa>;
> +		vddrfa0p95-supply = <&vreg_conn_1p8>;

How comes that 0.95V pin is powred on by 1.8V? How comes that 1.3V
pin is powered on by 1.8V?

> +		vddrfa1p3-supply = <&vreg_conn_pa>;
> +		vddrfa1p9-supply = <&vreg_conn_1p8>;
> +		vddpcie1p3-supply = <&vreg_conn_pa>;
> +		vddpcie1p9-supply = <&vreg_conn_1p8>;
> +
> +		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
> +
-- 
With best wishes
Dmitry
Re: [PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Posted by Wei Zhang (Stone) 2 weeks, 3 days ago
On 1/20/2026 3:44 PM, Dmitry Baryshkov wrote:
> On Mon, Jan 19, 2026 at 11:06:49PM -0800, Wei Zhang wrote:
>> Enable WLAN on qcs8300-ride by adding a node for the PMU module
>> of the WCN6855 and assigning its LDO power outputs to the existing
>> WiFi module.
>>
>> On the qcs8300-ride platform, the corresponding firmware and BDF
>> are QCA6698AQ instead of WCN6855, which have been added in the
>> 20250211 release.
>>
>> Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - PCIe
>> https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/
>>
>> Changes in v8:
>> - Reordered regulator nodes to maintain alphabetical consistency (Dmitry)
>> - Place wifi@0 node under existing pcieport0 label
>> - Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/
>>
>> Changes in v7:
>> - Align regulator node names to match the existing naming style in the dts (Dmitry)
>> - Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/
>>
>> Changes in v6:
>> - Rebase patches
>> - Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad)
>> - Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>>
>> Changes in v5:
>> - Rebase patches
>> - Flip the order of property-n and property-names (Konrad)
>> - Flip the order of bias and output property (Konrad)
>> - Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/
>>
>> Changes in v4:
>> - Rename the symbol pcieport0 to pcie0_port0 (Konrad)
>> - Adjust the property order in node pcie0_port0 (Konrad)
>> - Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry)
>> - Specify the calibration data using the correct variant (Dmitry)
>> - Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/
>>
>> Changes in v3:
>> - Complete the nodes property definitions according to DTS binding requirements (Bjorn)
>> - Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/
>>
>> Changes in v2:
>> - Rename the nodes name according to DTS coding style (Konrad & Krzysztof)
>> - Provide regulator-min/max-microvolt to the regulators (Konrad)
>> - Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++
>>   1 file changed, 105 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 68691f7b5f94..864b32503d29 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -24,6 +24,26 @@ chosen {
>>   		stdout-path = "serial0:115200n8";
>>   	};
>>   
>> +	vreg_conn_1p8: regulator-conn-1p8 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg_conn_1p8";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		startup-delay-us = <4000>;
>> +		enable-active-high;
>> +		gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> +	vreg_conn_pa: regulator-conn-pa {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg_conn_pa";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		startup-delay-us = <4000>;
>> +		enable-active-high;
>> +		gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>>   	regulator-usb2-vbus {
>>   		compatible = "regulator-fixed";
>>   		regulator-name = "USB2_VBUS";
>> @@ -33,6 +53,68 @@ regulator-usb2-vbus {
>>   		enable-active-high;
>>   		regulator-always-on;
>>   	};
>> +
>> +	wcn6855-pmu {
>> +		compatible = "qcom,wcn6855-pmu";
>> +
>> +		pinctrl-0 = <&wlan_en_state>;
>> +		pinctrl-names = "default";
>> +
>> +		vddio-supply = <&vreg_conn_pa>;
>> +		vddaon-supply = <&vreg_conn_1p8>;
>> +		vddpmu-supply = <&vreg_conn_pa>;
>> +		vddpmumx-supply = <&vreg_conn_1p8>;
>> +		vddpmucx-supply = <&vreg_conn_pa>;
>> +		vddrfa0p95-supply = <&vreg_conn_1p8>;
> How comes that 0.95V pin is powred on by 1.8V? How comes that 1.3V
> pin is powered on by 1.8V?
On this platform, all power domains of the WLAN module are enabled 
through external buck converters controlled by PMIC GPIO4.
PMIC‑C GPIO_4 is used for DBU3 ENABLE (PWR_CTRL2_VDD_1P8), and it is 
also used to enable the core voltages required by the WLAN card (1.95 V, 
1.35 V, 1.05 V. etc).
Do we also need to define a regulator for vddrfa1p3-supply, 
vddrfa1p9-supply, vddrfa0p95-supply, etc?
>
>> +		vddrfa1p3-supply = <&vreg_conn_pa>;
>> +		vddrfa1p9-supply = <&vreg_conn_1p8>;
>> +		vddpcie1p3-supply = <&vreg_conn_pa>;
>> +		vddpcie1p9-supply = <&vreg_conn_1p8>;
>> +
>> +		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
>> +
Re: [PATCH v8] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Posted by Dmitry Baryshkov 2 weeks, 3 days ago
On Wed, 21 Jan 2026 at 08:59, Wei Zhang (Stone)
<wei.zhang@oss.qualcomm.com> wrote:
>
>
> On 1/20/2026 3:44 PM, Dmitry Baryshkov wrote:
> > On Mon, Jan 19, 2026 at 11:06:49PM -0800, Wei Zhang wrote:
> >> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> >> of the WCN6855 and assigning its LDO power outputs to the existing
> >> WiFi module.
> >>
> >> On the qcs8300-ride platform, the corresponding firmware and BDF
> >> are QCA6698AQ instead of WCN6855, which have been added in the
> >> 20250211 release.
> >>
> >> Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
> >> ---
> >> This patch depends on:
> >> - PCIe
> >> https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/
> >>
> >> Changes in v8:
> >> - Reordered regulator nodes to maintain alphabetical consistency (Dmitry)
> >> - Place wifi@0 node under existing pcieport0 label
> >> - Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/
> >>
> >> Changes in v7:
> >> - Align regulator node names to match the existing naming style in the dts (Dmitry)
> >> - Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/
> >>
> >> Changes in v6:
> >> - Rebase patches
> >> - Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad)
> >> - Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
> >>
> >> Changes in v5:
> >> - Rebase patches
> >> - Flip the order of property-n and property-names (Konrad)
> >> - Flip the order of bias and output property (Konrad)
> >> - Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/
> >>
> >> Changes in v4:
> >> - Rename the symbol pcieport0 to pcie0_port0 (Konrad)
> >> - Adjust the property order in node pcie0_port0 (Konrad)
> >> - Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry)
> >> - Specify the calibration data using the correct variant (Dmitry)
> >> - Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/
> >>
> >> Changes in v3:
> >> - Complete the nodes property definitions according to DTS binding requirements (Bjorn)
> >> - Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/
> >>
> >> Changes in v2:
> >> - Rename the nodes name according to DTS coding style (Konrad & Krzysztof)
> >> - Provide regulator-min/max-microvolt to the regulators (Konrad)
> >> - Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/
> >> ---
> >>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 105 ++++++++++++++++++++++
> >>   1 file changed, 105 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> index 68691f7b5f94..864b32503d29 100644
> >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> @@ -24,6 +24,26 @@ chosen {
> >>              stdout-path = "serial0:115200n8";
> >>      };
> >>
> >> +    vreg_conn_1p8: regulator-conn-1p8 {
> >> +            compatible = "regulator-fixed";
> >> +            regulator-name = "vreg_conn_1p8";
> >> +            regulator-min-microvolt = <1800000>;
> >> +            regulator-max-microvolt = <1800000>;
> >> +            startup-delay-us = <4000>;
> >> +            enable-active-high;
> >> +            gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
> >> +    };
> >> +
> >> +    vreg_conn_pa: regulator-conn-pa {
> >> +            compatible = "regulator-fixed";
> >> +            regulator-name = "vreg_conn_pa";
> >> +            regulator-min-microvolt = <1800000>;
> >> +            regulator-max-microvolt = <1800000>;
> >> +            startup-delay-us = <4000>;
> >> +            enable-active-high;
> >> +            gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
> >> +    };
> >> +
> >>      regulator-usb2-vbus {
> >>              compatible = "regulator-fixed";
> >>              regulator-name = "USB2_VBUS";
> >> @@ -33,6 +53,68 @@ regulator-usb2-vbus {
> >>              enable-active-high;
> >>              regulator-always-on;
> >>      };
> >> +
> >> +    wcn6855-pmu {
> >> +            compatible = "qcom,wcn6855-pmu";
> >> +
> >> +            pinctrl-0 = <&wlan_en_state>;
> >> +            pinctrl-names = "default";
> >> +
> >> +            vddio-supply = <&vreg_conn_pa>;
> >> +            vddaon-supply = <&vreg_conn_1p8>;
> >> +            vddpmu-supply = <&vreg_conn_pa>;
> >> +            vddpmumx-supply = <&vreg_conn_1p8>;
> >> +            vddpmucx-supply = <&vreg_conn_pa>;
> >> +            vddrfa0p95-supply = <&vreg_conn_1p8>;
> > How comes that 0.95V pin is powred on by 1.8V? How comes that 1.3V
> > pin is powered on by 1.8V?
> On this platform, all power domains of the WLAN module are enabled
> through external buck converters controlled by PMIC GPIO4.
> PMIC‑C GPIO_4 is used for DBU3 ENABLE (PWR_CTRL2_VDD_1P8), and it is
> also used to enable the core voltages required by the WLAN card (1.95 V,
> 1.35 V, 1.05 V. etc).
> Do we also need to define a regulator for vddrfa1p3-supply,
> vddrfa1p9-supply, vddrfa0p95-supply, etc?

Could you please describe the hardware. Accurately. Not by using
clumsy shortcuts or incorrect simplifications.

> >
> >> +            vddrfa1p3-supply = <&vreg_conn_pa>;
> >> +            vddrfa1p9-supply = <&vreg_conn_1p8>;
> >> +            vddpcie1p3-supply = <&vreg_conn_pa>;
> >> +            vddpcie1p9-supply = <&vreg_conn_1p8>;
> >> +
> >> +            wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
> >> +



-- 
With best wishes
Dmitry