The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
MAC (version 5.40a) with some extra clock.
Add necessary compatible string for this device.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
.../devicetree/bindings/net/snps,dwmac.yaml | 3 +
.../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++
2 files changed, 110 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index dd3c72e8363e..3c2c6cb6b10b 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -34,6 +34,7 @@ select:
- snps,dwmac-5.10a
- snps,dwmac-5.20
- snps,dwmac-5.30a
+ - snps,dwmac-5.40a
- snps,dwxgmac
- snps,dwxgmac-2.10
@@ -108,6 +109,7 @@ properties:
- snps,dwmac-5.10a
- snps,dwmac-5.20
- snps,dwmac-5.30a
+ - snps,dwmac-5.40a
- snps,dwxgmac
- snps,dwxgmac-2.10
- sophgo,sg2042-dwmac
@@ -653,6 +655,7 @@ allOf:
- snps,dwmac-5.10a
- snps,dwmac-5.20
- snps,dwmac-5.30a
+ - snps,dwmac-5.40a
- snps,dwxgmac
- snps,dwxgmac-2.10
- st,spear600-gmac
diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
new file mode 100644
index 000000000000..58dd98f79e8a
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Spacemit K3 DWMAC glue layer
+
+maintainers:
+ - Inochi Amaoto <inochiama@gmail.com>
+
+select:
+ properties:
+ compatible:
+ contains:
+ const: spacemit,k3-dwmac
+ required:
+ - compatible
+
+properties:
+ compatible:
+ items:
+ - const: spacemit,k3-dwmac
+ - const: snps,dwmac-5.40a
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ minItems: 3
+ items:
+ - description: GMAC main clock
+ - description: PTP clock
+ - description: TX clock
+ - description: PHY clock
+
+ clock-names:
+ minItems: 3
+ items:
+ - const: stmmaceth
+ - const: ptp_ref
+ - const: tx
+ - const: phy
+
+ interrupts:
+ minItems: 1
+ items:
+ - description: MAC interrupt
+ - description: MAC wake interrupt
+
+ interrupt-names:
+ minItems: 1
+ items:
+ - const: macirq
+ - const: eth_wake_irq
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: stmmaceth
+
+ spacemit,apmu:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ items:
+ - items:
+ - description: phandle to the syscon node which control the glue register
+ - description: offset of the control register
+ - description: offset of the dline register
+
+ description:
+ A phandle to syscon with offset to control registers for this MAC
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+ - interrupt-names
+ - resets
+ - reset-names
+
+allOf:
+ - $ref: snps,dwmac.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ eth0: ethernet@cac80000 {
+ compatible = "spacemit,k3-dwmac", "snps,dwmac-5.40a";
+ reg = <0xcac80000 0x2000>;
+ clocks = <&syscon_apmu 66>, <&syscon_apmu 68>,
+ <&syscon_apmu 69>;
+ clock-names = "stmmaceth", "ptp_ref", "tx";
+ interrupts = <131 IRQ_TYPE_LEVEL_HIGH>, <276 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "macirq", "eth_wake_irq";
+ phy-mode = "rgmii-id";
+ phy-handle = <&phy0>;
+ resets = <&syscon_apmu 67>;
+ reset-names = "stmmaceth";
+ spacemit,apmu = <&syscon_apmu 0x384 0x38c>;
+ };
+
--
2.52.0On Tue, Jan 20, 2026 at 12:36:06PM +0800, Inochi Amaoto wrote: > The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare > MAC (version 5.40a) with some extra clock. > > Add necessary compatible string for this device. > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 3 + > .../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++ > 2 files changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml ... > diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > new file mode 100644 > index 000000000000..58dd98f79e8a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml ... > + clocks: > + minItems: 3 > + items: > + - description: GMAC main clock > + - description: PTP clock > + - description: TX clock > + - description: PHY clock Why does the MAC require "phy" clock? Shouldn't this be handled in PHY driver instead, or I get its meaning wrong? Also, I don't see "phy" clock is acquired anywhere in the driver. Is it really necessary for the MAC? Best regards, Yao Zi
On Tue, Jan 20, 2026 at 10:55:43AM +0000, Yao Zi wrote: > On Tue, Jan 20, 2026 at 12:36:06PM +0800, Inochi Amaoto wrote: > > The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare > > MAC (version 5.40a) with some extra clock. > > > > Add necessary compatible string for this device. > > > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 3 + > > .../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++ > > 2 files changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > ... > > > diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > new file mode 100644 > > index 000000000000..58dd98f79e8a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > ... > > > + clocks: > > + minItems: 3 > > + items: > > + - description: GMAC main clock > > + - description: PTP clock > > + - description: TX clock > > + - description: PHY clock > > Why does the MAC require "phy" clock? Shouldn't this be handled in PHY > driver instead, or I get its meaning wrong? > IIRC, the "phy" clock is used to pass the phy from the mac core, I will double check if it is possible to connect to the phy directly. > Also, I don't see "phy" clock is acquired anywhere in the driver. Is it > really necessary for the MAC? > This is a mistake, I remove this by accident, if it is necessary, I will add this in the next version. Regards, Inochi
> IIRC, the "phy" clock is used to pass the phy from the mac core, I will
> double check if it is possible to connect to the phy directly.
Are you saying this is the reference clock output from the MAC being
fed to the PHY? That would be a clock provider, not a clock consumer.
Or is it the reference clock output from the PHY going to the MAC?
Then the MAC would be a consumer.
And there are some designs which have a third party generate the
clock, and both the MAC and the PHY consume it.
Andrew
On Tue, Jan 20, 2026 at 02:48:12PM +0100, Andrew Lunn wrote: > > IIRC, the "phy" clock is used to pass the phy from the mac core, I will > > double check if it is possible to connect to the phy directly. > > Are you saying this is the reference clock output from the MAC being > fed to the PHY? That would be a clock provider, not a clock consumer. > > Or is it the reference clock output from the PHY going to the MAC? > Then the MAC would be a consumer. > > And there are some designs which have a third party generate the > clock, and both the MAC and the PHY consume it. > I have confirmed the clock is directly from the the clock tree and is consumed only by the PHY. It seems like I have got a wrong information about this. So let's remove it and let the phy consume the clock if it use this clock. Regards, Inochi
© 2016 - 2026 Red Hat, Inc.