[PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset

Konrad Dybcio posted 3 patches 2 weeks, 6 days ago
[PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset
Posted by Konrad Dybcio 2 weeks, 6 days ago
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

To make sure the core starts in a predictable state, it's useful to
first reset it.

Wire up the reset to fulfill that missing part of the HW description.

Reported-by: Val Packett <val@packett.cool>
Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 45b9864e3304..f7937fa88536 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3221,6 +3221,8 @@ mdss: display-subsystem@ae00000 {
 				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
 			clock-names = "iface", "ahb", "core";
 
+			resets = <&dispcc DISPCC_MDSS_CORE_BCR>;
+
 			interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-controller;
 			#interrupt-cells = <1>;

-- 
2.52.0
Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset
Posted by Dmitry Baryshkov 2 weeks, 6 days ago
On Tue, Jan 20, 2026 at 12:19:27PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> To make sure the core starts in a predictable state, it's useful to
> first reset it.
> 
> Wire up the reset to fulfill that missing part of the HW description.
> 
> Reported-by: Val Packett <val@packett.cool>

Closes?

> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Let's check that trogrod users don't have anything against it. Doug?

-- 
With best wishes
Dmitry
Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset
Posted by Konrad Dybcio 2 weeks, 5 days ago
On 1/20/26 11:03 PM, Dmitry Baryshkov wrote:
> On Tue, Jan 20, 2026 at 12:19:27PM +0100, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> To make sure the core starts in a predictable state, it's useful to
>> first reset it.
>>
>> Wire up the reset to fulfill that missing part of the HW description.
>>
>> Reported-by: Val Packett <val@packett.cool>
> 
> Closes?

Outside lkml

> 
>> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Let's check that trogrod users don't have anything against it. Doug?

Good point, I don't think there should be anything wrong with it
though..

Konrad
Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Add missing MDSS core reset
Posted by Konrad Dybcio 2 weeks, 6 days ago
On 1/20/26 12:19 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> To make sure the core starts in a predictable state, it's useful to
> first reset it.
> 
> Wire up the reset to fulfill that missing part of the HW description.
> 
> Reported-by: Val Packett <val@packett.cool>
> Fixes: a3db7ad1af49 ("arm64: dts: sc7180: add display dt nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 45b9864e3304..f7937fa88536 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3221,6 +3221,8 @@ mdss: display-subsystem@ae00000 {
>  				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
>  			clock-names = "iface", "ahb", "core";
>  
> +			resets = <&dispcc DISPCC_MDSS_CORE_BCR>;

^ won't compile without a _ between 'DISP' and 'CC', should have 
compile-tested harder..

Konrad