When calling of_parse_phandle_with_args(), the caller is responsible
to call of_node_put() to release the reference of device node.
In of_get_dml_pipe_index(), it does not release the reference.

Fixes: 9cb15142d0e3 ("mmc: mmci: Add qcom dml support to the driver.")
Signed-off-by: Felix Gu <gu_0233@qq.com>
---
 drivers/mmc/host/mmci_qcom_dml.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 3da6112fbe39..67371389cc33 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -109,6 +109,7 @@ static int of_get_dml_pipe_index(struct device_node *np, const char *name)
 				       &dma_spec))
 		return -ENODEV;
 
+	of_node_put(dma_spec.np);
 	if (dma_spec.args_count)
 		return dma_spec.args[0];
 

---
base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
change-id: 20260117-mmci_qcom_dml-e169407da7bf

Best regards,
-- 
Felix Gu <gu_0233@qq.com>

On Tue, 20 Jan 2026 at 15:26, Felix Gu <ustc.gu@gmail.com> wrote:
>
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In of_get_dml_pipe_index(), it does not release the reference.
>
> Fixes: 9cb15142d0e3 ("mmc: mmci: Add qcom dml support to the driver.")
> Signed-off-by: Felix Gu <gu_0233@qq.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mmci_qcom_dml.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
> index 3da6112fbe39..67371389cc33 100644
> --- a/drivers/mmc/host/mmci_qcom_dml.c
> +++ b/drivers/mmc/host/mmci_qcom_dml.c
> @@ -109,6 +109,7 @@ static int of_get_dml_pipe_index(struct device_node *np, const char *name)
>                                        &dma_spec))
>                 return -ENODEV;
>
> +       of_node_put(dma_spec.np);
>         if (dma_spec.args_count)
>                 return dma_spec.args[0];
>
>
> ---
> base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
> change-id: 20260117-mmci_qcom_dml-e169407da7bf
>
> Best regards,
> --
> Felix Gu <gu_0233@qq.com>
>