[PATCH] coco/tsm: Remove unused variable tsm_rwsem

Thomas Weißschuh posted 1 patch 2 weeks, 5 days ago
drivers/virt/coco/tsm-core.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] coco/tsm: Remove unused variable tsm_rwsem
Posted by Thomas Weißschuh 2 weeks, 5 days ago
This variable is and was never used, remove it.

Fixes: 603c646f0010 ("coco/tsm: Introduce a core device for TEE Security Managers")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 drivers/virt/coco/tsm-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/virt/coco/tsm-core.c b/drivers/virt/coco/tsm-core.c
index f027876a2f19..d02764a171c9 100644
--- a/drivers/virt/coco/tsm-core.c
+++ b/drivers/virt/coco/tsm-core.c
@@ -5,7 +5,6 @@
 
 #include <linux/tsm.h>
 #include <linux/pci.h>
-#include <linux/rwsem.h>
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/cleanup.h>
@@ -13,7 +12,6 @@
 #include <linux/pci-ide.h>
 
 static struct class *tsm_class;
-static DECLARE_RWSEM(tsm_rwsem);
 static DEFINE_IDA(tsm_ida);
 
 static int match_id(struct device *dev, const void *data)

---
base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
change-id: 20260120-coco-tsm_rwsem-8f1fde13ca6e

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH] coco/tsm: Remove unused variable tsm_rwsem
Posted by dan.j.williams@intel.com 2 weeks, 2 days ago
Thomas Weißschuh wrote:
> This variable is and was never used, remove it.
> 
> Fixes: 603c646f0010 ("coco/tsm: Introduce a core device for TEE Security Managers")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Hey, sorry for missing this earlier. Looks good and now applied, will
push out out tsm.git#fixes shortly.
Re: [PATCH] coco/tsm: Remove unused variable tsm_rwsem
Posted by John B. Wyatt IV 2 weeks, 2 days ago
On Tue, Jan 20, 2026 at 01:07:11PM +0100, Thomas Weißschuh wrote:
> This variable is and was never used, remove it.

Hello Dan,

What is the status of this fix? Without this my builds are breaking with
CONFIG_WERROR=y set.

As per process/handling-regressions.rst; I am CCing regressions.

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat