[v1] rv/rvgen: Robustness, modernization, and fixes

[PATCH 21/26] rv/rvgen: remove unused sys import from dot2c

Posted by Wander Lairson Costa 2 weeks, 5 days ago

The sys module was imported in the dot2c frontend script but never
used. This import was likely left over from earlier development or
copied from a template that required sys for exit handling.

Remove the unused import to clean up the code and satisfy linters
that flag unused imports as errors.

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
 tools/verification/rvgen/dot2c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/verification/rvgen/dot2c b/tools/verification/rvgen/dot2c
index bf0c67c5b66c8..1012becc7fab6 100644
--- a/tools/verification/rvgen/dot2c
+++ b/tools/verification/rvgen/dot2c
@@ -16,7 +16,6 @@
 if __name__ == '__main__':
     from rvgen import dot2c
     import argparse
-    import sys
 
     parser = argparse.ArgumentParser(description='dot2c: converts a .dot file into a C structure')
     parser.add_argument('dot_file',  help='The dot file to be converted')
-- 
2.52.0

Re: [PATCH 21/26] rv/rvgen: remove unused sys import from dot2c

Posted by Gabriele Monaco 2 weeks, 5 days ago

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> The sys module was imported in the dot2c frontend script but never
> used. This import was likely left over from earlier development or
> copied from a template that required sys for exit handling.
> 
> Remove the unused import to clean up the code and satisfy linters
> that flag unused imports as errors.
> 
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>

Good catch, thanks!

Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>

> ---
>  tools/verification/rvgen/dot2c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/verification/rvgen/dot2c b/tools/verification/rvgen/dot2c
> index bf0c67c5b66c8..1012becc7fab6 100644
> --- a/tools/verification/rvgen/dot2c
> +++ b/tools/verification/rvgen/dot2c
> @@ -16,7 +16,6 @@
>  if __name__ == '__main__':
>      from rvgen import dot2c
>      import argparse
> -    import sys
>  
>      parser = argparse.ArgumentParser(description='dot2c: converts a .dot file
> into a C structure')
>      parser.add_argument('dot_file',  help='The dot file to be converted')