[PATCH 2/6] x86/cpu: Add missing #include

Dave Hansen posted 6 patches 2 weeks, 6 days ago
There is a newer version of this series
[PATCH 2/6] x86/cpu: Add missing #include
Posted by Dave Hansen 2 weeks, 6 days ago

From: Dave Hansen <dave.hansen@linux.intel.com>

The intel-family.h header uses Vendor/Family/Model macros but it does not
#include the header where they are defined. It must be depending on implicit
includes.

Include the required header explicitly.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: x86@kernel.org
Cc: Jon Kohler <jon@nutanix.com>
---

 b/arch/x86/include/asm/intel-family.h |    2 ++
 1 file changed, 2 insertions(+)

diff -puN arch/x86/include/asm/intel-family.h~fam-missing-include arch/x86/include/asm/intel-family.h
--- a/arch/x86/include/asm/intel-family.h~fam-missing-include	2026-01-19 11:38:08.254872476 -0800
+++ b/arch/x86/include/asm/intel-family.h	2026-01-19 11:38:08.257872590 -0800
@@ -2,6 +2,8 @@
 #ifndef _ASM_X86_INTEL_FAMILY_H
 #define _ASM_X86_INTEL_FAMILY_H
 
+#include <asm/vfm.h>
+
 /*
  * "Big Core" Processors (Branded as Core, Xeon, etc...)
  *
_
Re: [PATCH 2/6] x86/cpu: Add missing #include
Posted by Dave Hansen 2 weeks, 6 days ago
On 1/19/26 11:50, Dave Hansen wrote:
> diff -puN arch/x86/include/asm/intel-family.h~fam-missing-include arch/x86/include/asm/intel-family.h
> --- a/arch/x86/include/asm/intel-family.h~fam-missing-include	2026-01-19 11:38:08.254872476 -0800
> +++ b/arch/x86/include/asm/intel-family.h	2026-01-19 11:38:08.257872590 -0800
> @@ -2,6 +2,8 @@
>  #ifndef _ASM_X86_INTEL_FAMILY_H
>  #define _ASM_X86_INTEL_FAMILY_H
>  
> +#include <asm/vfm.h>
> +
>  /*
>   * "Big Core" Processors (Branded as Core, Xeon, etc...)
>   *

In a private 0-day mail, it told me:

> On 1/19/26 15:33, kernel test robot wrote:
> ...> config: parisc-randconfig-001-20260120...>    In file included from include/linux/peci-cpu.h:33,
>>                     from drivers/peci/device.c:6:
>>>> include/linux/../../arch/x86/include/asm/intel-family.h:5:10: fatal error: asm/vfm.h: No such file or directory
>>     #include <asm/vfm.h>
>>              ^~~~~~~~~~~
>>    compilation terminated.
>> 
>> 
>> vim +5 include/linux/../../arch/x86/include/asm/intel-family.h

I made a change to intel-family.h and it broke a parisc config. All
thanks to the PECI header that does:

 #include "../../arch/x86/include/asm/intel-family.h"

in arch-independent code. I'll fix this up in a v2 but reviews on v1 are
still appreciated.
Re: [PATCH 2/6] x86/cpu: Add missing #include
Posted by Andy Shevchenko 2 weeks, 5 days ago
On Mon, Jan 19, 2026 at 04:26:33PM -0800, Dave Hansen wrote:
> On 1/19/26 11:50, Dave Hansen wrote:

> In a private 0-day mail, it told me:

There are two reports publicly available.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 2/6] x86/cpu: Add missing #include
Posted by Dave Hansen 2 weeks, 5 days ago
On 1/20/26 00:19, Andy Shevchenko wrote:
> On Mon, Jan 19, 2026 at 04:26:33PM -0800, Dave Hansen wrote:
>> On 1/19/26 11:50, Dave Hansen wrote:
>> In a private 0-day mail, it told me:
> There are two reports publicly available.

By "private", I meant "not cc'd to LKML nor any of the folks on this cc
list". There is a lore link for it, though, which I guess I could have used.

But I mainly wanted to tell the folks who were reading this via LKML or
who were on cc why they didn't see the report. Oh, and one of those
reports was sent *after* I sent this message.

I'd much rather have you look at the code or changelogs!