lib/test_min_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The module description incorrectly mentions "min max heap", but the
test module is specifically designed for testing the min heap
implementation. Correct the metadata to match the code.
Signed-off-by: Nick Huang <sef1548@gmail.com>
---
lib/test_min_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
index a9c4a74d3..9e42a805b 100644
--- a/lib/test_min_heap.c
+++ b/lib/test_min_heap.c
@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
}
module_exit(test_min_heap_exit);
-MODULE_DESCRIPTION("Test cases for the min max heap");
+MODULE_DESCRIPTION("Test cases for the min heap");
MODULE_LICENSE("GPL");
--
2.43.0
Hi Nick,
On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> The module description incorrectly mentions "min max heap", but the
> test module is specifically designed for testing the min heap
> implementation. Correct the metadata to match the code.
Thanks for the patch, but I don't think this change is necessary.
As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
the implementation easily supports a max heap by simply inverting
the comparison function.
Since this module explicitly tests both min heap and max heap
scenarios, the current description accurately reflects the test
coverage.
Regards,
Kuan-Wei
>
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> ---
> lib/test_min_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
> index a9c4a74d3..9e42a805b 100644
> --- a/lib/test_min_heap.c
> +++ b/lib/test_min_heap.c
> @@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
> }
> module_exit(test_min_heap_exit);
>
> -MODULE_DESCRIPTION("Test cases for the min max heap");
> +MODULE_DESCRIPTION("Test cases for the min heap");
> MODULE_LICENSE("GPL");
> --
> 2.43.0
>
© 2016 - 2026 Red Hat, Inc.