[PATCH net-next v1] mctp i2c: align function parameter indentation

Haiyue Wang posted 1 patch 2 weeks, 5 days ago
drivers/net/mctp/mctp-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH net-next v1] mctp i2c: align function parameter indentation
Posted by Haiyue Wang 2 weeks, 5 days ago
Align parameters of mctp_i2c_header_create() to improve readability
and match kernel coding style. No functional change.

Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
 drivers/net/mctp/mctp-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c
index f782d93f826e..362eaebf7c5b 100644
--- a/drivers/net/mctp/mctp-i2c.c
+++ b/drivers/net/mctp/mctp-i2c.c
@@ -578,7 +578,7 @@ static void mctp_i2c_flow_release(struct mctp_i2c_dev *midev)
 
 static int mctp_i2c_header_create(struct sk_buff *skb, struct net_device *dev,
 				  unsigned short type, const void *daddr,
-	   const void *saddr, unsigned int len)
+				  const void *saddr, unsigned int len)
 {
 	struct mctp_i2c_hdr *hdr;
 	struct mctp_hdr *mhdr;
-- 
2.52.0
Re: [PATCH net-next v1] mctp i2c: align function parameter indentation
Posted by Jakub Kicinski 2 weeks, 4 days ago
On Mon, 19 Jan 2026 15:00:06 +0800 Haiyue Wang wrote:
> Align parameters of mctp_i2c_header_create() to improve readability
> and match kernel coding style. No functional change.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: cr