[PATCH net-next v2 2/2] net: ethernet: litex: use device pointer to simplify code.

Inochi Amaoto posted 2 patches 2 weeks, 6 days ago
[PATCH net-next v2 2/2] net: ethernet: litex: use device pointer to simplify code.
Posted by Inochi Amaoto 2 weeks, 6 days ago
As there is already a device pointer in the probe function, replace
all "&pdev->dev" pattern with this predefined device pointer.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/net/ethernet/litex/litex_liteeth.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 67ad1058c2ab..670f2a406d7d 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -238,7 +238,7 @@ static int liteeth_probe(struct platform_device *pdev)
 	struct liteeth *priv;
 	int irq, err;
 
-	netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
+	netdev = devm_alloc_etherdev(dev, sizeof(*priv));
 	if (!netdev)
 		return -ENOMEM;
 
@@ -247,10 +247,9 @@ static int liteeth_probe(struct platform_device *pdev)
 
 	priv = netdev_priv(netdev);
 	priv->netdev = netdev;
-	priv->dev = &pdev->dev;
+	priv->dev = dev;
 
-	netdev->tstats = devm_netdev_alloc_pcpu_stats(&pdev->dev,
-						      struct pcpu_sw_netstats);
+	netdev->tstats = devm_netdev_alloc_pcpu_stats(dev, struct pcpu_sw_netstats);
 	if (!netdev->tstats)
 		return -ENOMEM;
 
@@ -277,7 +276,7 @@ static int liteeth_probe(struct platform_device *pdev)
 	priv->tx_base = buf_base + priv->num_rx_slots * priv->slot_size;
 	priv->tx_slot = 0;
 
-	err = of_get_ethdev_address(pdev->dev.of_node, netdev);
+	err = of_get_ethdev_address(dev->of_node, netdev);
 	if (err)
 		eth_hw_addr_random(netdev);
 
@@ -285,7 +284,7 @@ static int liteeth_probe(struct platform_device *pdev)
 
 	err = devm_register_netdev(dev, netdev);
 	if (err) {
-		dev_err(&pdev->dev, "Failed to register netdev %d\n", err);
+		dev_err(dev, "Failed to register netdev %d\n", err);
 		return err;
 	}
 
-- 
2.52.0
Re: [PATCH net-next v2 2/2] net: ethernet: litex: use device pointer to simplify code.
Posted by Andrew Lunn 2 weeks, 4 days ago
> -	netdev->tstats = devm_netdev_alloc_pcpu_stats(&pdev->dev,
> -						      struct pcpu_sw_netstats);
> +	netdev->tstats = devm_netdev_alloc_pcpu_stats(dev, struct pcpu_sw_netstats);

Is that longer than 80 characters? netdev keeps with the lower limit.

Otherwise

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew