[PATCH v4 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1

Mithil Bavishi posted 10 patches 2 weeks, 5 days ago
There is a newer version of this series
[PATCH v4 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1
Posted by Mithil Bavishi 2 weeks, 5 days ago
Add samsung-espresso10 codename for the 10 inch variant

Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index d8774c676..f694dcbf2 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -145,6 +145,7 @@ properties:
               - motorola,xyboard-mz609
               - motorola,xyboard-mz617
               - samsung,espresso7
+              - samsung,espresso10
               - ti,omap4-panda
               - ti,omap4-sdp
           - const: ti,omap4430
-- 
2.43.0
Re: [PATCH v4 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1
Posted by Krzysztof Kozlowski 2 weeks, 5 days ago
On 19/01/2026 04:30, Mithil Bavishi wrote:
> Add samsung-espresso10 codename for the 10 inch variant
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>


<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof
Re: [PATCH v4 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1
Posted by Krzysztof Kozlowski 2 weeks, 5 days ago
On 19/01/2026 08:16, Krzysztof Kozlowski wrote:
> On 19/01/2026 04:30, Mithil Bavishi wrote:
>> Add samsung-espresso10 codename for the 10 inch variant
>>
>> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> 
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 

Both comments... When you receive a comment under one patch, you must
check if it does not apply to others. This is really sloppy to send me a
patch with exactly the same problem, which I asked to fix already.

Best regards,
Krzysztof