[PATCH] drm/tests: hdmi: fix build failure

Dmitry Baryshkov posted 1 patch 2 weeks, 5 days ago
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/tests: hdmi: fix build failure
Posted by Dmitry Baryshkov 2 weeks, 5 days ago
The commit ca59e33f5a1f ("drm/atomic: add max_size check to
drm_property_replace_blob_from_id()") added a new parameter to
drm_property_replace_blob_from_id(), however commit 7436a87db99d
("drm/tests: hdmi: check the infoframes behaviour") was based on the
older tree and used the old number of params (with me failing to run
kunit tests when applying).

Fix the build error by specifying -1 as the max_size (as expected).

Fixes: 7436a87db99d ("drm/tests: hdmi: check the infoframes behaviour")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601200306.dgF5deFm-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
index 1c60947a13a1..13e405979e33 100644
--- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
@@ -2779,7 +2779,7 @@ static void drm_test_check_reject_hdr_infoframe_bpc_10(struct kunit *test)
 	ret = drm_property_replace_blob_from_id(drm,
 						&new_conn_state->hdr_output_metadata,
 						hdr_blob->base.id,
-						sizeof(struct hdr_output_metadata), -1,
+						-1, sizeof(struct hdr_output_metadata), -1,
 						&replaced);
 	KUNIT_ASSERT_EQ(test, ret, 0);
 	KUNIT_ASSERT_EQ(test, replaced, true);

---
base-commit: ab4c3dcf9a71582503b4fb25aeab884c696cab25
change-id: 20260119-fix-kunit-infoframe-24550437558a

Best regards,
-- 
With best wishes
Dmitry
Re: [PATCH] drm/tests: hdmi: fix build failure
Posted by Dmitry Baryshkov 2 weeks, 4 days ago
On Mon, 19 Jan 2026 22:08:09 +0200, Dmitry Baryshkov wrote:
> The commit ca59e33f5a1f ("drm/atomic: add max_size check to
> drm_property_replace_blob_from_id()") added a new parameter to
> drm_property_replace_blob_from_id(), however commit 7436a87db99d
> ("drm/tests: hdmi: check the infoframes behaviour") was based on the
> older tree and used the old number of params (with me failing to run
> kunit tests when applying).
> 
> [...]

Applied to drm-misc-next, thanks!

[1/1] drm/tests: hdmi: fix build failure
      commit: d1c0978a7e7864fcaa7cdd562a8f938afcd2ad39

Best regards,
-- 
With best wishes
Dmitry
Re: [PATCH] drm/tests: hdmi: fix build failure
Posted by Luca Ceresoli 2 weeks, 4 days ago
On Mon Jan 19, 2026 at 9:08 PM CET, Dmitry Baryshkov wrote:
> The commit ca59e33f5a1f ("drm/atomic: add max_size check to
> drm_property_replace_blob_from_id()") added a new parameter to
> drm_property_replace_blob_from_id(), however commit 7436a87db99d
> ("drm/tests: hdmi: check the infoframes behaviour") was based on the
> older tree and used the old number of params (with me failing to run
> kunit tests when applying).
>
> Fix the build error by specifying -1 as the max_size (as expected).
>
> Fixes: 7436a87db99d ("drm/tests: hdmi: check the infoframes behaviour")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601200306.dgF5deFm-lkp@intel.com/
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com