[PATCH] iio: pressure: mprls0025pa: remove error message

Petre Rodan posted 1 patch 2 weeks, 5 days ago
drivers/iio/pressure/mprls0025pa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] iio: pressure: mprls0025pa: remove error message
Posted by Petre Rodan 2 weeks, 5 days ago
Do not print a duplicate error message if devm_request_irq() fails.

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
A tiny followup to the mprls driver cleanup, as requested by Andy [1]

This patch is against testing, since at the time of my pull the
cleanup was not present in the togreg branch. I hope it's fine.

best regards,
peter

Link: https://lore.kernel.org/linux-iio/20260116190153.082b9cc0@jic23-huawei/T/#mbf1be48fe2bc58c0c065f8598e80d623326976f3 [1]
---
 drivers/iio/pressure/mprls0025pa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/pressure/mprls0025pa.c b/drivers/iio/pressure/mprls0025pa.c
index 587d0dcad89b..e8c495f336ff 100644
--- a/drivers/iio/pressure/mprls0025pa.c
+++ b/drivers/iio/pressure/mprls0025pa.c
@@ -413,8 +413,7 @@ int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)
 		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, 0,
 				       dev_name(dev), data);
 		if (ret)
-			return dev_err_probe(dev, ret,
-					  "request irq %d failed\n", data->irq);
+			return ret;
 	}
 
 	data->gpiod_reset = devm_gpiod_get_optional(dev, "reset",

---
base-commit: c30e80d68a7afb334fde7147ee0106f25dd58d3a
change-id: 20260118-mprl_driver_followup-bdab25d42ccd

Best regards,
-- 
Petre Rodan <petre.rodan@subdimension.ro>
Re: [PATCH] iio: pressure: mprls0025pa: remove error message
Posted by Andy Shevchenko 2 weeks, 4 days ago
On Sun, Jan 18, 2026 at 01:19:39PM +0200, Petre Rodan wrote:
> Do not print a duplicate error message if devm_request_irq() fails.

> Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> ---
> A tiny followup to the mprls driver cleanup, as requested by Andy [1]

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH] iio: pressure: mprls0025pa: remove error message
Posted by Jonathan Cameron 2 weeks, 1 day ago
On Mon, 19 Jan 2026 10:10:46 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sun, Jan 18, 2026 at 01:19:39PM +0200, Petre Rodan wrote:
> > Do not print a duplicate error message if devm_request_irq() fails.  
> 
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
> > ---
> > A tiny followup to the mprls driver cleanup, as requested by Andy [1]  
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

Applied.

Thanks!

J