An upcoming change will add more channel parameters.
This leads to a lot of churn and very long lines.
Use a macro to encapsulate all of the shared values.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hwmon/cros_ec_hwmon.c | 49 ++++++++++++++++++++++---------------------
1 file changed, 25 insertions(+), 24 deletions(-)
diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c
index 53abd55cba05..f5be293fdaa6 100644
--- a/drivers/hwmon/cros_ec_hwmon.c
+++ b/drivers/hwmon/cros_ec_hwmon.c
@@ -310,31 +310,32 @@ static const struct hwmon_channel_info * const cros_ec_hwmon_info[] = {
HWMON_PWM_INPUT | HWMON_PWM_ENABLE,
HWMON_PWM_INPUT | HWMON_PWM_ENABLE,
HWMON_PWM_INPUT | HWMON_PWM_ENABLE),
+#define CROS_EC_HWMON_TEMP_PARAMS (HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL)
HWMON_CHANNEL_INFO(temp,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL,
- HWMON_T_INPUT | HWMON_T_FAULT | HWMON_T_LABEL),
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS,
+ CROS_EC_HWMON_TEMP_PARAMS),
NULL
};
--
2.52.0
On Sun, Jan 18, 2026 at 10:45:57AM +0100, Thomas Weißschuh wrote: > An upcoming change will add more channel parameters. > This leads to a lot of churn and very long lines. > > Use a macro to encapsulate all of the shared values. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> Applied. Thanks, Guenter
On Sun, Jan 18, 2026 at 10:45:57AM +0100, Thomas Weißschuh wrote: > An upcoming change will add more channel parameters. > This leads to a lot of churn and very long lines. > > Use a macro to encapsulate all of the shared values. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
© 2016 - 2026 Red Hat, Inc.