[PATCH v2 3/3] spi: dt-bindings: xilinx: make interrupts optional

Abdurrahman Hussain posted 3 patches 3 weeks, 2 days ago
[PATCH v2 3/3] spi: dt-bindings: xilinx: make interrupts optional
Posted by Abdurrahman Hussain 3 weeks, 2 days ago
This makes the driver work on platforms where interrupts are either not
provided or broken.

Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
 Documentation/devicetree/bindings/spi/spi-xilinx.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
index 4beb3af0416d..24e62530d432 100644
--- a/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-xilinx.yaml
@@ -38,7 +38,6 @@ properties:
 required:
   - compatible
   - reg
-  - interrupts
 
 unevaluatedProperties: false
 
-- 
2.52.0
Re: [PATCH v2 3/3] spi: dt-bindings: xilinx: make interrupts optional
Posted by Andrew Lunn 3 weeks, 2 days ago
On Sat, Jan 17, 2026 at 01:21:36AM +0000, Abdurrahman Hussain wrote:
> This makes the driver work on platforms where interrupts are either not
> provided or broken.

In addition to Krzysztof comment, please do try to read all the links
to documents i sent you.

Point 5 of the binding document says:

    The Documentation/ portion of the patch should come in the series
    before the code implementing the binding.

This might sound nit picky, but there is a huge volume of patches
which need reviewing, and in order to make that possible we have
processes to make it simpler to do. Please keep to the processes,
particularly if you plan to stick around and become a regular
contributor.

    Andrew

---
pw-bot: cr
Re: [PATCH v2 3/3] spi: dt-bindings: xilinx: make interrupts optional
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On Sat, Jan 17, 2026 at 01:21:36AM +0000, Abdurrahman Hussain wrote:
> This makes the driver work on platforms where interrupts are either not
> provided or broken.

Please slow down with your patchset. One patchset per 24h so you will
actually give people chance to review them. I just posted comments for
your v1.

Also one more note (please address v1 comments first):
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Best regards,
Krzysztof