[v2] arm64: dts: imx8m*: misc update

[PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

Posted by Frank Li 3 weeks, 1 day ago

From: Li Jun <jun.li@nxp.com>

USB phy can be wakeup source to support wakeup system from USB.

Signed-off-by: Li Jun <jun.li@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index f2e1854f38a0a83927f19d0f8630a9d0e5f81aa1..4b662fd7753755f513c172ce30105d4447bd96d7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -274,6 +274,7 @@ usbphynop1: usbphynop1 {
 		assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_100M>;
 		clock-names = "main_clk";
 		power-domains = <&pgc_otg1>;
+		wakeup-source;
 	};
 
 	usbphynop2: usbphynop2 {
@@ -284,6 +285,7 @@ usbphynop2: usbphynop2 {
 		assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_100M>;
 		clock-names = "main_clk";
 		power-domains = <&pgc_otg2>;
+		wakeup-source;
 	};
 
 	soc: soc@0 {

-- 
2.34.1

Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

Posted by Marco Felsch 3 weeks ago

On 26-01-17, Frank Li wrote:
> From: Li Jun <jun.li@nxp.com>
> 
> USB phy can be wakeup source to support wakeup system from USB.

Was USB wakeup tested? That beeing said, marking the device as
wakeup-src is fine.

> Signed-off-by: Li Jun <jun.li@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

Posted by Marco Felsch 3 weeks ago

On 26-01-18, Marco Felsch wrote:
> On 26-01-17, Frank Li wrote:
> > From: Li Jun <jun.li@nxp.com>
> > 
> > USB phy can be wakeup source to support wakeup system from USB.
> 
> Was USB wakeup tested? That beeing said, marking the device as
> wakeup-src is fine.
> 
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Just noticed that this targets the base soc.dtsi. IMHO this is board
desicion to make and therefore belongs to the real board.dts(i) or dtso.

Therefore please drop my r-b.

Regards,
  Marco


-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

Posted by Frank Li 2 weeks, 6 days ago

On Sun, Jan 18, 2026 at 06:29:46PM +0100, Marco Felsch wrote:
> On 26-01-18, Marco Felsch wrote:
> > On 26-01-17, Frank Li wrote:
> > > From: Li Jun <jun.li@nxp.com>
> > >
> > > USB phy can be wakeup source to support wakeup system from USB.
> >
> > Was USB wakeup tested? That beeing said, marking the device as
> > wakeup-src is fine.
> >
> > > Signed-off-by: Li Jun <jun.li@nxp.com>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Just noticed that this targets the base soc.dtsi. IMHO this is board
> desicion to make and therefore belongs to the real board.dts(i) or dtso.
>
> Therefore please drop my r-b.

wakeup-source is captiblity of hardware. The user need use echo 1 > wakeup
to enable it. it is SOC's feature.

Frank

>
> Regards,
>   Marco
>
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

Posted by Marco Felsch 2 weeks, 6 days ago

On 26-01-19, Frank Li wrote:
> On Sun, Jan 18, 2026 at 06:29:46PM +0100, Marco Felsch wrote:
> > On 26-01-18, Marco Felsch wrote:
> > > On 26-01-17, Frank Li wrote:
> > > > From: Li Jun <jun.li@nxp.com>
> > > >
> > > > USB phy can be wakeup source to support wakeup system from USB.
> > >
> > > Was USB wakeup tested? That beeing said, marking the device as
> > > wakeup-src is fine.
> > >
> > > > Signed-off-by: Li Jun <jun.li@nxp.com>
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > >
> > > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> >
> > Just noticed that this targets the base soc.dtsi. IMHO this is board
> > desicion to make and therefore belongs to the real board.dts(i) or dtso.
> >
> > Therefore please drop my r-b.
> 
> wakeup-source is captiblity of hardware. The user need use echo 1 > wakeup
> to enable it. it is SOC's feature.

I know that but still if the your system doesn't want to have the usb
exposed as wakeup-source in the first place, the board.dts(i) files are
now forced to delete this property. Therefore IMHO it's still a board
decision to make.

Regards,
  Marco


> 
> Frank
> 
> >
> > Regards,
> >   Marco
> >
> >
> > --
> > #gernperDu
> > #CallMeByMyFirstName
> >
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |