[PATCH v3 15/27] gpib: hp_82335: Unify *allocate_private usage

Dominik Karol Piątkowski posted 27 patches 3 weeks, 3 days ago
[PATCH v3 15/27] gpib: hp_82335: Unify *allocate_private usage
Posted by Dominik Karol Piątkowski 3 weeks, 3 days ago
Use the return value of hp82335_allocate_private in calling code as
early return value in case of error.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
---

v3:
- Split commit into smaller pieces
- Improve changelog
- Change `(retval < 0)` to `(retval)`

 drivers/gpib/hp_82335/hp82335.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpib/hp_82335/hp82335.c b/drivers/gpib/hp_82335/hp82335.c
index 6717fa437d31..9baf1d3b6751 100644
--- a/drivers/gpib/hp_82335/hp82335.c
+++ b/drivers/gpib/hp_82335/hp82335.c
@@ -253,8 +253,9 @@ static int hp82335_attach(struct gpib_board *board, const struct gpib_board_conf
 
 	board->status = 0;
 
-	if (hp82335_allocate_private(board))
-		return -ENOMEM;
+	retval = hp82335_allocate_private(board);
+	if (retval)
+		return retval;
 	hp_priv = board->private_data;
 	tms_priv = &hp_priv->tms9914_priv;
 	tms_priv->read_byte = hp82335_read_byte;
-- 
2.43.0