[PATCH v3 13/27] gpib: gpio: Unify *allocate_private usage

Dominik Karol Piątkowski posted 27 patches 3 weeks, 3 days ago
[PATCH v3 13/27] gpib: gpio: Unify *allocate_private usage
Posted by Dominik Karol Piątkowski 3 weeks, 3 days ago
Use the return value of allocate_private in calling code as early return
value in case of error.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
---

v3:
- Split commit into smaller pieces
- Improve changelog
- Change `(retval < 0)` to `(retval)`

 drivers/gpib/gpio/gpib_bitbang.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpib/gpio/gpib_bitbang.c b/drivers/gpib/gpio/gpib_bitbang.c
index 62adcab1ddfb..ba99d6c95ddf 100644
--- a/drivers/gpib/gpio/gpib_bitbang.c
+++ b/drivers/gpib/gpio/gpib_bitbang.c
@@ -1205,14 +1205,15 @@ static void bb_detach(struct gpib_board *board)
 static int bb_attach(struct gpib_board *board, const struct gpib_board_config *config)
 {
 	struct bb_priv *priv;
-	int retval = 0;
+	int retval;
 
 	dbg_printk(2, "%s\n", "Enter ...");
 
 	board->status = 0;
 
-	if (allocate_private(board))
-		return -ENOMEM;
+	retval = allocate_private(board);
+	if (retval)
+		return retval;
 	priv = board->private_data;
 	priv->direction = -1;
 	priv->t1_delay = 2000;
-- 
2.43.0