[PATCH v2 2/3] media: dt-bindings: venus: Fix iommus property

Sumit Garg posted 3 patches 3 weeks, 1 day ago
There is a newer version of this series
[PATCH v2 2/3] media: dt-bindings: venus: Fix iommus property
Posted by Sumit Garg 3 weeks, 1 day ago
From: Sumit Garg <sumit.garg@oss.qualcomm.com>

Fix IOMMU DT propety for venus via dropping SMMU stream IDs which
relates to secure context bank. Assigning Linux kernel (HLOS) VMID
to secure context bank stream IDs is incorrect.

The min value is added for iommus property to ensure in future when
secure context bank stream IDs are properly supported then the iommus
property is extensible.

These DT bindings changes should be backwards compatible.

Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 .../devicetree/bindings/media/qcom,qcm2290-venus.yaml       | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
index 3f3ee82fc878..ae6bc0d0bea6 100644
--- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
@@ -42,6 +42,7 @@ properties:
       - const: vcodec0_bus
 
   iommus:
+    minItems: 2
     maxItems: 5
 
   interconnects:
@@ -102,10 +103,7 @@ examples:
         memory-region = <&pil_video_mem>;
 
         iommus = <&apps_smmu 0x860 0x0>,
-                 <&apps_smmu 0x880 0x0>,
-                 <&apps_smmu 0x861 0x04>,
-                 <&apps_smmu 0x863 0x0>,
-                 <&apps_smmu 0x804 0xe0>;
+                 <&apps_smmu 0x880 0x0>;
 
         interconnects = <&mmnrt_virt MASTER_VIDEO_P0 RPM_ALWAYS_TAG
                          &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>,
-- 
2.51.0
Re: [PATCH v2 2/3] media: dt-bindings: venus: Fix iommus property
Posted by Krzysztof Kozlowski 3 weeks, 1 day ago
On Fri, Jan 16, 2026 at 11:50:03AM +0530, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> 
> Fix IOMMU DT propety for venus via dropping SMMU stream IDs which
> relates to secure context bank. Assigning Linux kernel (HLOS) VMID
> to secure context bank stream IDs is incorrect.
> 
> The min value is added for iommus property to ensure in future when

You do not add min value (that would be "minimum") but change the list.

> secure context bank stream IDs are properly supported then the iommus
> property is extensible.
> 
> These DT bindings changes should be backwards compatible.
> 
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/media/qcom,qcm2290-venus.yaml       | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> index 3f3ee82fc878..ae6bc0d0bea6 100644
> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> @@ -42,6 +42,7 @@ properties:
>        - const: vcodec0_bus
>  
>    iommus:
> +    minItems: 2

Same problem.

>      maxItems: 5

Best regards,
Krzysztof