From: Yijie Yang <yijie.yang@oss.qualcomm.com>
The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of
the Purwa IoT SoM and a carrier board. Together, they form a complete
embedded system capable of booting to UART.
PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK.
Meanwhile, USB0 bypasses the SBU selector FSUSB42.
Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio
- PCIe ports for PCIe3 through PCIe6a
- TPM
Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../{hamoa-iot-evk.dts => purwa-iot-evk.dts} | 112 ++++++++++++------
2 files changed, 75 insertions(+), 38 deletions(-)
copy arch/arm64/boot/dts/qcom/{hamoa-iot-evk.dts => purwa-iot-evk.dts} (95%)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index a5d6f451f85c..d276b3cf14ee 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -126,6 +126,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb
+dtb-$(CONFIG_ARCH_QCOM) += purwa-iot-evk.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcm6490-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcm6490-particle-tachyon.dtb
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
similarity index 95%
copy from arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
copy to arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
index 2390648a248f..2a2cbcd9eace 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
@@ -6,12 +6,12 @@
/dts-v1/;
#include <dt-bindings/leds/common.h>
-#include "hamoa-iot-som.dtsi"
+#include "purwa-iot-som.dtsi"
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
/ {
- model = "Qualcomm Technologies, Inc. Hamoa IoT EVK";
- compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";
+ model = "Qualcomm Technologies, Inc. Purwa IoT EVK";
+ compatible = "qcom,purwa-iot-evk", "qcom,purwa-iot-som", "qcom,x1p42100";
chassis-type = "embedded";
aliases {
@@ -118,15 +118,15 @@ port@1 {
reg = <1>;
pmic_glink_ss0_ss_in: endpoint {
- remote-endpoint = <&usb_1_ss0_qmpphy_out>;
+ remote-endpoint = <&retimer_ss0_ss_out>;
};
};
port@2 {
reg = <2>;
- pmic_glink_ss0_sbu: endpoint {
- remote-endpoint = <&usb_1_ss0_sbu_mux>;
+ pmic_glink_ss0_con_sbu_in: endpoint {
+ remote-endpoint = <&retimer_ss0_con_sbu_out>;
};
};
};
@@ -618,25 +618,6 @@ platform {
};
};
- usb-1-ss0-sbu-mux {
- compatible = "onnn,fsusb42", "gpio-sbu-mux";
-
- enable-gpios = <&tlmm 168 GPIO_ACTIVE_LOW>;
- select-gpios = <&tlmm 167 GPIO_ACTIVE_HIGH>;
-
- pinctrl-0 = <&usb_1_ss0_sbu_default>;
- pinctrl-names = "default";
-
- mode-switch;
- orientation-switch;
-
- port {
- usb_1_ss0_sbu_mux: endpoint {
- remote-endpoint = <&pmic_glink_ss0_sbu>;
- };
- };
- };
-
wcn7850-pmu {
compatible = "qcom,wcn7850-pmu";
@@ -753,6 +734,63 @@ retimer_ss2_con_sbu_out: endpoint {
};
};
+&i2c3 {
+ clock-frequency = <400000>;
+
+ status = "okay";
+
+ typec-mux@8 {
+ compatible = "parade,ps8830";
+ reg = <0x8>;
+
+ clocks = <&rpmhcc RPMH_RF_CLK4>;
+
+ vdd-supply = <&vreg_rtmr0_1p15>;
+ vdd33-supply = <&vreg_rtmr0_3p3>;
+ vdd33-cap-supply = <&vreg_rtmr0_3p3>;
+ vddar-supply = <&vreg_rtmr0_1p15>;
+ vddat-supply = <&vreg_rtmr0_1p15>;
+ vddio-supply = <&vreg_rtmr0_1p8>;
+
+ reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
+
+ pinctrl-0 = <&rtmr0_default>;
+ pinctrl-names = "default";
+
+ retimer-switch;
+ orientation-switch;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ retimer_ss0_ss_out: endpoint {
+ remote-endpoint = <&pmic_glink_ss0_ss_in>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ retimer_ss0_ss_in: endpoint {
+ remote-endpoint = <&usb_1_ss0_qmpphy_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ retimer_ss0_con_sbu_out: endpoint {
+ remote-endpoint = <&pmic_glink_ss0_con_sbu_in>;
+ };
+ };
+ };
+ };
+};
+
&i2c5 {
clock-frequency = <400000>;
@@ -1102,9 +1140,7 @@ edp_bl_reg_en: edp-bl-reg-en-state {
pins = "gpio10";
function = "normal";
};
-};
-&pmc8380_3_gpios {
pm_sde7_aux_3p3_en: pcie-aux-3p3-default-state {
pins = "gpio8";
function = "normal";
@@ -1144,6 +1180,16 @@ &pmk8550_pwm {
status = "okay";
};
+&spi11 {
+ status = "okay";
+
+ tpm@0 {
+ compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+};
+
&smb2360_0 {
status = "okay";
};
@@ -1171,16 +1217,6 @@ &smb2360_2_eusb2_repeater {
vdd3-supply = <&vreg_l8b_3p0>;
};
-&spi11 {
- status = "okay";
-
- tpm@0 {
- compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
- reg = <0>;
- spi-max-frequency = <20000000>;
- };
-};
-
&swr0 {
status = "okay";
@@ -1470,7 +1506,7 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy_out {
- remote-endpoint = <&pmic_glink_ss0_ss_in>;
+ remote-endpoint = <&retimer_ss0_ss_in>;
};
&usb_1_ss1_dwc3_hs {
--
2.34.1On 1/16/26 11:41 AM, YijieYang wrote:
> From: Yijie Yang <yijie.yang@oss.qualcomm.com>
>
> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of
> the Purwa IoT SoM and a carrier board. Together, they form a complete
> embedded system capable of booting to UART.
>
> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK.
> Meanwhile, USB0 bypasses the SBU selector FSUSB42.
>
> Make the following peripherals on the carrier board enabled:
> - UART
> - On-board regulators
> - USB Type-C mux
> - Pinctrl
> - Embedded USB (EUSB) repeaters
> - NVMe
> - pmic-glink
> - USB DisplayPorts
> - Bluetooth
> - WLAN
> - Audio
> - PCIe ports for PCIe3 through PCIe6a
> - TPM
>
> Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
> ---
[...]
> +&spi11 {
> + status = "okay";
> +
> + tpm@0 {
> + compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> +};
> +
> &smb2360_0 {
> status = "okay";
> };
> @@ -1171,16 +1217,6 @@ &smb2360_2_eusb2_repeater {
> vdd3-supply = <&vreg_l8b_3p0>;
> };
>
> -&spi11 {
> - status = "okay";
> -
> - tpm@0 {
> - compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
> - reg = <0>;
> - spi-max-frequency = <20000000>;
> - };
> -};
Not sure if anyone commented on this already, please keep it where
it was (it was properly sorted in the original file), then we're just
left with the USB changes
Konrad
On 1/19/2026 9:53 PM, Konrad Dybcio wrote:
> On 1/16/26 11:41 AM, YijieYang wrote:
>> From: Yijie Yang <yijie.yang@oss.qualcomm.com>
>>
>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of
>> the Purwa IoT SoM and a carrier board. Together, they form a complete
>> embedded system capable of booting to UART.
>>
>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK.
>> Meanwhile, USB0 bypasses the SBU selector FSUSB42.
>>
>> Make the following peripherals on the carrier board enabled:
>> - UART
>> - On-board regulators
>> - USB Type-C mux
>> - Pinctrl
>> - Embedded USB (EUSB) repeaters
>> - NVMe
>> - pmic-glink
>> - USB DisplayPorts
>> - Bluetooth
>> - WLAN
>> - Audio
>> - PCIe ports for PCIe3 through PCIe6a
>> - TPM
>>
>> Signed-off-by: Yijie Yang <yijie.yang@oss.qualcomm.com>
>> ---
>
> [...]
>
>
>> +&spi11 {
>> + status = "okay";
>> +
>> + tpm@0 {
>> + compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
>> + reg = <0>;
>> + spi-max-frequency = <20000000>;
>> + };
>> +};
>> +
>> &smb2360_0 {
>> status = "okay";
>> };
>> @@ -1171,16 +1217,6 @@ &smb2360_2_eusb2_repeater {
>> vdd3-supply = <&vreg_l8b_3p0>;
>> };
>>
>> -&spi11 {
>> - status = "okay";
>> -
>> - tpm@0 {
>> - compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
>> - reg = <0>;
>> - spi-max-frequency = <20000000>;
>> - };
>> -};
>
> Not sure if anyone commented on this already, please keep it where
> it was (it was properly sorted in the original file), then we're just
> left with the USB changes
>
Will update.
> Konrad
--
Best Regards,
Yijie
On 16/01/2026 11:41, YijieYang wrote: > From: Yijie Yang <yijie.yang@oss.qualcomm.com> > > The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of > the Purwa IoT SoM and a carrier board. Together, they form a complete > embedded system capable of booting to UART. > > PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. > Meanwhile, USB0 bypasses the SBU selector FSUSB42. > NAK. Warnings were reported at v3. Did you address them? No, you completely ignored them, so warnings are reported again at v4. What do you think these emails are for? Best regards, Krzysztof
On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: > On 16/01/2026 11:41, YijieYang wrote: >> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >> >> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >> the Purwa IoT SoM and a carrier board. Together, they form a complete >> embedded system capable of booting to UART. >> >> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >> > > NAK. > > Warnings were reported at v3. Did you address them? No, you completely > ignored them, so warnings are reported again at v4. > > What do you think these emails are for? This warning is caused by the pcie3_phy node in purwa.dtsi, which is not introduced by this patch set. Since it does not impact functionality, would it be appropriate to fix it in a separate patch? > > Best regards, > Krzysztof -- Best Regards, Yijie
On 19/01/2026 04:13, Yijie Yang wrote: > > > On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >> On 16/01/2026 11:41, YijieYang wrote: >>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>> >>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>> embedded system capable of booting to UART. >>> >>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>> >> >> NAK. >> >> Warnings were reported at v3. Did you address them? No, you completely >> ignored them, so warnings are reported again at v4. >> >> What do you think these emails are for? > > This warning is caused by the pcie3_phy node in purwa.dtsi, which is not > introduced by this patch set. Since it does not impact functionality, Your patchset introduces that warning. There was no such warning before. My NAK still stays, such patchset must not be merged. Best regards, Krzysztof
On 1/19/2026 3:05 PM, Krzysztof Kozlowski wrote: > On 19/01/2026 04:13, Yijie Yang wrote: >> >> >> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>> On 16/01/2026 11:41, YijieYang wrote: >>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>> >>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>> embedded system capable of booting to UART. >>>> >>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>> >>> >>> NAK. >>> >>> Warnings were reported at v3. Did you address them? No, you completely >>> ignored them, so warnings are reported again at v4. >>> >>> What do you think these emails are for? >> >> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >> introduced by this patch set. Since it does not impact functionality, > > Your patchset introduces that warning. There was no such warning before. > > My NAK still stays, such patchset must not be merged. This patch series can continue to be reviewed with the dependency noted, right? https://lore.kernel.org/linux-arm-msm/20260119-topic-purwa_phy_shutup_warning-v1-1-997a692b31c6@oss.qualcomm.com/T/#u > > Best regards, > Krzysztof -- Best Regards, Yijie
On 20/01/2026 07:49, Yijie Yang wrote: > > > On 1/19/2026 3:05 PM, Krzysztof Kozlowski wrote: >> On 19/01/2026 04:13, Yijie Yang wrote: >>> >>> >>> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>>> On 16/01/2026 11:41, YijieYang wrote: >>>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>>> >>>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>>> embedded system capable of booting to UART. >>>>> >>>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>>> >>>> >>>> NAK. >>>> >>>> Warnings were reported at v3. Did you address them? No, you completely >>>> ignored them, so warnings are reported again at v4. >>>> >>>> What do you think these emails are for? >>> >>> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >>> introduced by this patch set. Since it does not impact functionality, >> >> Your patchset introduces that warning. There was no such warning before. >> >> My NAK still stays, such patchset must not be merged. > > This patch series can continue to be reviewed with the dependency noted, > right? > https://lore.kernel.org/linux-arm-msm/20260119-topic-purwa_phy_shutup_warning-v1-1-997a692b31c6@oss.qualcomm.com/T/#u It's not a dependency. You only need to mention where the bindings are addressing the issue, preferably in patch changelog. Best regards, Krzysztof
On 1/20/2026 3:17 PM, Krzysztof Kozlowski wrote: > On 20/01/2026 07:49, Yijie Yang wrote: >> >> >> On 1/19/2026 3:05 PM, Krzysztof Kozlowski wrote: >>> On 19/01/2026 04:13, Yijie Yang wrote: >>>> >>>> >>>> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>>>> On 16/01/2026 11:41, YijieYang wrote: >>>>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>>>> >>>>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>>>> embedded system capable of booting to UART. >>>>>> >>>>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>>>> >>>>> >>>>> NAK. >>>>> >>>>> Warnings were reported at v3. Did you address them? No, you completely >>>>> ignored them, so warnings are reported again at v4. >>>>> >>>>> What do you think these emails are for? >>>> >>>> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >>>> introduced by this patch set. Since it does not impact functionality, >>> >>> Your patchset introduces that warning. There was no such warning before. >>> >>> My NAK still stays, such patchset must not be merged. >> >> This patch series can continue to be reviewed with the dependency noted, >> right? >> https://lore.kernel.org/linux-arm-msm/20260119-topic-purwa_phy_shutup_warning-v1-1-997a692b31c6@oss.qualcomm.com/T/#u > > It's not a dependency. You only need to mention where the bindings are > addressing the issue, preferably in patch changelog. Sure, will update. > > Best regards, > Krzysztof -- Best Regards, Yijie
On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: > > > On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: > > On 16/01/2026 11:41, YijieYang wrote: > > > From: Yijie Yang <yijie.yang@oss.qualcomm.com> > > > > > > The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of > > > the Purwa IoT SoM and a carrier board. Together, they form a complete > > > embedded system capable of booting to UART. > > > > > > PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. > > > Meanwhile, USB0 bypasses the SBU selector FSUSB42. > > > > > > > NAK. > > > > Warnings were reported at v3. Did you address them? No, you completely > > ignored them, so warnings are reported again at v4. > > > > What do you think these emails are for? > > This warning is caused by the pcie3_phy node in purwa.dtsi, which is not > introduced by this patch set. Since it does not impact functionality, would > it be appropriate to fix it in a separate patch? Why can't it be fixed as a part of this patchset? > > > > > Best regards, > > Krzysztof > > -- > Best Regards, > Yijie > -- With best wishes Dmitry
On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: >> >> >> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>> On 16/01/2026 11:41, YijieYang wrote: >>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>> >>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>> embedded system capable of booting to UART. >>>> >>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>> >>> >>> NAK. >>> >>> Warnings were reported at v3. Did you address them? No, you completely >>> ignored them, so warnings are reported again at v4. >>> >>> What do you think these emails are for? >> >> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >> introduced by this patch set. Since it does not impact functionality, would >> it be appropriate to fix it in a separate patch? > > Why can't it be fixed as a part of this patchset? 'qcom,4ln-config-sel' is a property related to bifurcated PHY support, which Purwa’s PCIe3 does not provide. Therefore, introducing a new compatible with a corresponding binding would be more appropriate than simply adding this property. Is it acceptable to address this within the current patch set? > >> >>> >>> Best regards, >>> Krzysztof >> >> -- >> Best Regards, >> Yijie >> > -- Best Regards, Yijie
On Mon, Jan 19, 2026 at 04:48:20PM +0800, Yijie Yang wrote: > > > On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: > > On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: > > > > > > > > > On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: > > > > On 16/01/2026 11:41, YijieYang wrote: > > > > > From: Yijie Yang <yijie.yang@oss.qualcomm.com> > > > > > > > > > > The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of > > > > > the Purwa IoT SoM and a carrier board. Together, they form a complete > > > > > embedded system capable of booting to UART. > > > > > > > > > > PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. > > > > > Meanwhile, USB0 bypasses the SBU selector FSUSB42. > > > > > > > > > > > > > NAK. > > > > > > > > Warnings were reported at v3. Did you address them? No, you completely > > > > ignored them, so warnings are reported again at v4. > > > > > > > > What do you think these emails are for? > > > > > > This warning is caused by the pcie3_phy node in purwa.dtsi, which is not > > > introduced by this patch set. Since it does not impact functionality, would > > > it be appropriate to fix it in a separate patch? > > > > Why can't it be fixed as a part of this patchset? > > 'qcom,4ln-config-sel' is a property related to bifurcated PHY support, which > Purwa’s PCIe3 does not provide. Therefore, introducing a new compatible with > a corresponding binding would be more appropriate than simply adding this > property. Is it acceptable to address this within the current patch set? Within this or in the separate patchset, but it needs to be fixed before this patch can go in. Otherwise we are enabling broken PCIe3. > > > > > > > > > > > > > > Best regards, > > > > Krzysztof > > > > > > -- > > > Best Regards, > > > Yijie > > > > > > > -- > Best Regards, > Yijie > -- With best wishes Dmitry
On 1/19/26 10:46 AM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 04:48:20PM +0800, Yijie Yang wrote: >> >> >> On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: >>> On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: >>>> >>>> >>>> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>>>> On 16/01/2026 11:41, YijieYang wrote: >>>>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>>>> >>>>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>>>> embedded system capable of booting to UART. >>>>>> >>>>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>>>> >>>>> >>>>> NAK. >>>>> >>>>> Warnings were reported at v3. Did you address them? No, you completely >>>>> ignored them, so warnings are reported again at v4. >>>>> >>>>> What do you think these emails are for? >>>> >>>> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >>>> introduced by this patch set. Since it does not impact functionality, would >>>> it be appropriate to fix it in a separate patch? >>> >>> Why can't it be fixed as a part of this patchset? >> >> 'qcom,4ln-config-sel' is a property related to bifurcated PHY support, which >> Purwa’s PCIe3 does not provide. Therefore, introducing a new compatible with >> a corresponding binding would be more appropriate than simply adding this >> property. Is it acceptable to address this within the current patch set? > > Within this or in the separate patchset, but it needs to be fixed before > this patch can go in. Otherwise we are enabling broken PCIe3. https://lore.kernel.org/linux-arm-msm/20260119-topic-purwa_phy_shutup_warning-v1-1-997a692b31c6@oss.qualcomm.com/T/#u Konrad
On 1/19/2026 9:31 PM, Konrad Dybcio wrote: > On 1/19/26 10:46 AM, Dmitry Baryshkov wrote: >> On Mon, Jan 19, 2026 at 04:48:20PM +0800, Yijie Yang wrote: >>> >>> >>> On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: >>>> On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: >>>>> >>>>> >>>>> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>>>>> On 16/01/2026 11:41, YijieYang wrote: >>>>>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>>>>> >>>>>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>>>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>>>>> embedded system capable of booting to UART. >>>>>>> >>>>>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>>>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>>>>> >>>>>> >>>>>> NAK. >>>>>> >>>>>> Warnings were reported at v3. Did you address them? No, you completely >>>>>> ignored them, so warnings are reported again at v4. >>>>>> >>>>>> What do you think these emails are for? >>>>> >>>>> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >>>>> introduced by this patch set. Since it does not impact functionality, would >>>>> it be appropriate to fix it in a separate patch? >>>> >>>> Why can't it be fixed as a part of this patchset? >>> >>> 'qcom,4ln-config-sel' is a property related to bifurcated PHY support, which >>> Purwa’s PCIe3 does not provide. Therefore, introducing a new compatible with >>> a corresponding binding would be more appropriate than simply adding this >>> property. Is it acceptable to address this within the current patch set? >> >> Within this or in the separate patchset, but it needs to be fixed before >> this patch can go in. Otherwise we are enabling broken PCIe3. > > https://lore.kernel.org/linux-arm-msm/20260119-topic-purwa_phy_shutup_warning-v1-1-997a692b31c6@oss.qualcomm.com/T/#u Thanks, I can add this as a dependency. > > Konrad -- Best Regards, Yijie
On 1/19/2026 5:46 PM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 04:48:20PM +0800, Yijie Yang wrote: >> >> >> On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: >>> On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: >>>> >>>> >>>> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>>>> On 16/01/2026 11:41, YijieYang wrote: >>>>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>>>> >>>>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>>>> embedded system capable of booting to UART. >>>>>> >>>>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>>>> >>>>> >>>>> NAK. >>>>> >>>>> Warnings were reported at v3. Did you address them? No, you completely >>>>> ignored them, so warnings are reported again at v4. >>>>> >>>>> What do you think these emails are for? >>>> >>>> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >>>> introduced by this patch set. Since it does not impact functionality, would >>>> it be appropriate to fix it in a separate patch? >>> >>> Why can't it be fixed as a part of this patchset? >> >> 'qcom,4ln-config-sel' is a property related to bifurcated PHY support, which >> Purwa’s PCIe3 does not provide. Therefore, introducing a new compatible with >> a corresponding binding would be more appropriate than simply adding this >> property. Is it acceptable to address this within the current patch set? > > Within this or in the separate patchset, but it needs to be fixed before > this patch can go in. Otherwise we are enabling broken PCIe3. OK, will fix. > >> >>> >>>> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> -- >>>> Best Regards, >>>> Yijie >>>> >>> >> >> -- >> Best Regards, >> Yijie >> > -- Best Regards, Yijie
On 1/19/2026 2:33 PM, Dmitry Baryshkov wrote: > On Mon, Jan 19, 2026 at 11:13:29AM +0800, Yijie Yang wrote: >> >> >> On 1/17/2026 12:19 AM, Krzysztof Kozlowski wrote: >>> On 16/01/2026 11:41, YijieYang wrote: >>>> From: Yijie Yang <yijie.yang@oss.qualcomm.com> >>>> >>>> The PURWA-IOT-EVK is an evaluation platform for IoT products, composed of >>>> the Purwa IoT SoM and a carrier board. Together, they form a complete >>>> embedded system capable of booting to UART. >>>> >>>> PURWA-IOT-EVK uses the PS8833 as a retimer for USB0, unlike HAMOA-IOT-EVK. >>>> Meanwhile, USB0 bypasses the SBU selector FSUSB42. >>>> >>> >>> NAK. >>> >>> Warnings were reported at v3. Did you address them? No, you completely >>> ignored them, so warnings are reported again at v4. >>> >>> What do you think these emails are for? >> >> This warning is caused by the pcie3_phy node in purwa.dtsi, which is not >> introduced by this patch set. Since it does not impact functionality, would >> it be appropriate to fix it in a separate patch? > > Why can't it be fixed as a part of this patchset? I will fix this after evaluating the impact of this feature. > >> >>> >>> Best regards, >>> Krzysztof >> >> -- >> Best Regards, >> Yijie >> > -- Best Regards, Yijie
© 2016 - 2026 Red Hat, Inc.