[PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging

Jai Luthra posted 2 patches 3 weeks, 3 days ago
[PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging
Posted by Jai Luthra 3 weeks, 3 days ago
The starfive-camss driver is no longer being worked upon for destaging,
and will be dropped in a subsequent commit, so drop the DT bindings.

Link: https://lore.kernel.org/all/ZQ0PR01MB13024A92926C415C187D2C18F29F2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn/
Acked-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 .../bindings/media/starfive,jh7110-camss.yaml      | 180 ---------------------
 MAINTAINERS                                        |   1 -
 2 files changed, 181 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
deleted file mode 100644
index c66586d90fa2b4199da758d9dd4ae470e24fda91..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
+++ /dev/null
@@ -1,180 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Starfive SoC CAMSS ISP
-
-maintainers:
-  - Jack Zhu <jack.zhu@starfivetech.com>
-  - Changhuang Liang <changhuang.liang@starfivetech.com>
-
-description:
-  The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
-  consists of a VIN controller (Video In Controller, a top-level control unit)
-  and an ISP.
-
-properties:
-  compatible:
-    const: starfive,jh7110-camss
-
-  reg:
-    maxItems: 2
-
-  reg-names:
-    items:
-      - const: syscon
-      - const: isp
-
-  clocks:
-    maxItems: 7
-
-  clock-names:
-    items:
-      - const: apb_func
-      - const: wrapper_clk_c
-      - const: dvp_inv
-      - const: axiwr
-      - const: mipi_rx0_pxl
-      - const: ispcore_2x
-      - const: isp_axi
-
-  resets:
-    maxItems: 6
-
-  reset-names:
-    items:
-      - const: wrapper_p
-      - const: wrapper_c
-      - const: axird
-      - const: axiwr
-      - const: isp_top_n
-      - const: isp_top_axi
-
-  power-domains:
-    items:
-      - description: JH7110 ISP Power Domain Switch Controller.
-
-  interrupts:
-    maxItems: 4
-
-  ports:
-    $ref: /schemas/graph.yaml#/properties/ports
-
-    properties:
-      port@0:
-        $ref: /schemas/graph.yaml#/$defs/port-base
-        unevaluatedProperties: false
-        description: Input port for receiving DVP data.
-
-        properties:
-          endpoint:
-            $ref: video-interfaces.yaml#
-            unevaluatedProperties: false
-
-            properties:
-              bus-type:
-                enum: [5, 6]
-
-              bus-width:
-                enum: [8, 10, 12]
-
-              data-shift:
-                enum: [0, 2]
-                default: 0
-
-              hsync-active:
-                enum: [0, 1]
-                default: 1
-
-              vsync-active:
-                enum: [0, 1]
-                default: 1
-
-            required:
-              - bus-type
-              - bus-width
-
-      port@1:
-        $ref: /schemas/graph.yaml#/properties/port
-        description: Input port for receiving CSI data.
-
-    required:
-      - port@0
-      - port@1
-
-required:
-  - compatible
-  - reg
-  - reg-names
-  - clocks
-  - clock-names
-  - resets
-  - reset-names
-  - power-domains
-  - interrupts
-  - ports
-
-additionalProperties: false
-
-examples:
-  - |
-    isp@19840000 {
-        compatible = "starfive,jh7110-camss";
-        reg = <0x19840000 0x10000>,
-              <0x19870000 0x30000>;
-        reg-names = "syscon", "isp";
-        clocks = <&ispcrg 0>,
-                 <&ispcrg 13>,
-                 <&ispcrg 2>,
-                 <&ispcrg 12>,
-                 <&ispcrg 1>,
-                 <&syscrg 51>,
-                 <&syscrg 52>;
-        clock-names = "apb_func",
-                      "wrapper_clk_c",
-                      "dvp_inv",
-                      "axiwr",
-                      "mipi_rx0_pxl",
-                      "ispcore_2x",
-                      "isp_axi";
-        resets = <&ispcrg 0>,
-                 <&ispcrg 1>,
-                 <&ispcrg 10>,
-                 <&ispcrg 11>,
-                 <&syscrg 41>,
-                 <&syscrg 42>;
-        reset-names = "wrapper_p",
-                      "wrapper_c",
-                      "axird",
-                      "axiwr",
-                      "isp_top_n",
-                      "isp_top_axi";
-        power-domains = <&pwrc 5>;
-        interrupts = <92>, <87>, <88>, <90>;
-
-        ports {
-            #address-cells = <1>;
-            #size-cells = <0>;
-            port@0 {
-                reg = <0>;
-                vin_from_sc2235: endpoint {
-                    remote-endpoint = <&sc2235_to_vin>;
-                    bus-type = <5>;
-                    bus-width = <8>;
-                    data-shift = <2>;
-                    hsync-active = <1>;
-                    vsync-active = <0>;
-                    pclk-sample = <1>;
-                };
-            };
-
-            port@1 {
-                reg = <1>;
-                vin_from_csi2rx: endpoint {
-                    remote-endpoint = <&csi2rx_to_vin>;
-                };
-            };
-        };
-    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b11839cba9de1e9e43f63787578edd8c429ca39..5e19700e9152b103c194003b4421e6bc26022608 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -24853,7 +24853,6 @@ M:	Changhuang Liang <changhuang.liang@starfivetech.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/admin-guide/media/starfive_camss.rst
-F:	Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
 F:	drivers/staging/media/starfive/camss
 
 STARFIVE CRYPTO DRIVER

-- 
2.52.0
Re: [PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging
Posted by Krzysztof Kozlowski 3 weeks, 1 day ago
On Fri, Jan 16, 2026 at 12:36:58PM +0530, Jai Luthra wrote:
> The starfive-camss driver is no longer being worked upon for destaging,
> and will be dropped in a subsequent commit, so drop the DT bindings.
> 
> Link: https://lore.kernel.org/all/ZQ0PR01MB13024A92926C415C187D2C18F29F2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn/
> Acked-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
>  .../bindings/media/starfive,jh7110-camss.yaml      | 180 ---------------------
>  MAINTAINERS                                        |   1 -
>  2 files changed, 181 deletions(-)
> 

Please revert the order of patches when applying.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof
Re: [PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On Fri, Jan 16, 2026 at 12:36:58PM +0530, Jai Luthra wrote:
> The starfive-camss driver is no longer being worked upon for destaging,
> and will be dropped in a subsequent commit, so drop the DT bindings.

That's a moderately new SoC and commit was added ~2 years ago. Why is
this being dropped exactly?

> 
> Link: https://lore.kernel.org/all/ZQ0PR01MB13024A92926C415C187D2C18F29F2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn/
> Acked-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>

Reverting/dropping changes is always in reverse of introducing them, so
this must be second commit. Otherwise your change is non-bisectable and
you have now warnings of undocumented ABI.

Best regards,
Krzysztof
Re: [PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On 17/01/2026 12:36, Krzysztof Kozlowski wrote:
> On Fri, Jan 16, 2026 at 12:36:58PM +0530, Jai Luthra wrote:
>> The starfive-camss driver is no longer being worked upon for destaging,
>> and will be dropped in a subsequent commit, so drop the DT bindings.
> 
> That's a moderately new SoC and commit was added ~2 years ago. Why is
> this being dropped exactly?

OK, the link below gives some answer but isn't this better just to mark
it orphan and keep for some time? Is the driver working/useful? Maybe
someone will volunteer for it?

> 
>>
>> Link: https://lore.kernel.org/all/ZQ0PR01MB13024A92926C415C187D2C18F29F2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn/
>> Acked-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> 
> Reverting/dropping changes is always in reverse of introducing them, so
> this must be second commit. Otherwise your change is non-bisectable and
> you have now warnings of undocumented ABI.
> 
> Best regards,
> Krzysztof
> 


Best regards,
Krzysztof
Re: [PATCH v2 1/2] media: dt-bindings: Drop starfive,jh7110-camss from staging
Posted by Laurent Pinchart 3 weeks, 1 day ago
On Sat, Jan 17, 2026 at 12:38:21PM +0100, Krzysztof Kozlowski wrote:
> On 17/01/2026 12:36, Krzysztof Kozlowski wrote:
> > On Fri, Jan 16, 2026 at 12:36:58PM +0530, Jai Luthra wrote:
> >> The starfive-camss driver is no longer being worked upon for destaging,
> >> and will be dropped in a subsequent commit, so drop the DT bindings.
> > 
> > That's a moderately new SoC and commit was added ~2 years ago. Why is
> > this being dropped exactly?
> 
> OK, the link below gives some answer but isn't this better just to mark
> it orphan and keep for some time? Is the driver working/useful? Maybe
> someone will volunteer for it?

It's in staging, nobody has registered any interest, the company behind
the hardware as publicly said they won't continue development, and
there's no documentation. I think that meets the bar for dropping the
driver. In the very unlikely case someone would want to revive it, the
source code will live in git history.

> >> Link: https://lore.kernel.org/all/ZQ0PR01MB13024A92926C415C187D2C18F29F2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn/
> >> Acked-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> >> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> > 
> > Reverting/dropping changes is always in reverse of introducing them, so
> > this must be second commit. Otherwise your change is non-bisectable and
> > you have now warnings of undocumented ABI.

We can easily do that when applying.

-- 
Regards,

Laurent Pinchart