mm/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Change the declaration of 'seq' from 'unsigned' to 'unsigned int'
to follow kernel coding style. No functional change.
Signed-off-by: Manish Kumar <manish1588@gmail.com>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 231950d9d5c0..5e132ead5ea0 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -577,7 +577,7 @@ void __meminit init_pageblock_migratetype(struct page *page,
static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
{
int ret;
- unsigned seq;
+ unsigned int seq;
unsigned long pfn = page_to_pfn(page);
unsigned long sp, start_pfn;
@@ -659,7 +659,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order)
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
bool movable;
-
+
if (order > PAGE_ALLOC_COSTLY_ORDER) {
VM_BUG_ON(order != HPAGE_PMD_ORDER);
--
2.43.0
On Fri, Jan 16, 2026 at 01:18:45AM +0530, Manish Kumar wrote: > Change the declaration of 'seq' from 'unsigned' to 'unsigned int' > to follow kernel coding style. No functional change. Please don't send these kind of unnecessary cleanup patches to mm.
On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <manish1588@gmail.com> wrote: > Change the declaration of 'seq' from 'unsigned' to 'unsigned int' > to follow kernel coding style. No functional change. > > Signed-off-by: Manish Kumar <manish1588@gmail.com> Hello Manish, I hope you're doing well! The patch looks good to me. However, I just have a few comments about the other patches that you've recently sent out as well. I think it could be very helpful for reviewers, if you grouped related commits together (in this case, mm/page_alloc.c cleanups) into a single patchset. This lets the reviewers view all related commits together, in each others' contexts. It would also be super helpful to Cc some of the reviewers / maintainers who are relevant to the change you are making! scripts/get_maintainer.pl will give you a good idea of who might be people who are expereinced in the area and are willing to review the patch. Thank you for the patchset, have a great day! Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
On Thu, 15 Jan 2026 15:07:52 -0500 Joshua Hahn <joshua.hahnjy@gmail.com> wrote: > On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <manish1588@gmail.com> wrote: > > > Change the declaration of 'seq' from 'unsigned' to 'unsigned int' > > to follow kernel coding style. No functional change. > > > > Signed-off-by: Manish Kumar <manish1588@gmail.com> > > Hello Manish, I hope you're doing well! > > The patch looks good to me. However, I just have a few comments about the > other patches that you've recently sent out as well. > > I think it could be very helpful for reviewers, if you grouped related commits > together (in this case, mm/page_alloc.c cleanups) into a single patchset. > This lets the reviewers view all related commits together, in each others' > contexts. > > It would also be super helpful to Cc some of the reviewers / maintainers who > are relevant to the change you are making! scripts/get_maintainer.pl will > give you a good idea of who might be people who are expereinced in the area > and are willing to review the patch. > > Thank you for the patchset, have a great day! > > Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com> Whoops, one more thing. The deletion of an empty tab is included in this patch, but it's not mentioned at all in the changelog. Before adding my reviewed-by, please elaborate on it in the changelog, or submit it in a separate patch.
© 2016 - 2026 Red Hat, Inc.