[PATCH 1/4] dt-bindings: i2c: add support for Andes I2C controller

Ben Zong-You Xie posted 4 patches 3 weeks, 3 days ago
[PATCH 1/4] dt-bindings: i2c: add support for Andes I2C controller
Posted by Ben Zong-You Xie 3 weeks, 3 days ago
Document device tree bindings for Andes I2C controller.

Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
---
 .../bindings/i2c/andestech,atciic100.yaml     | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml

diff --git a/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
new file mode 100644
index 000000000000..dcbcafc8d6bd
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/andestech,atciic100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Andes I2C controller on QiLai SoC and AE350 platform
+
+maintainers:
+  - Ben Zong-You Xie <ben717@andestech.com>
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - andestech,qilai-i2c
+          - andestech,ae350-i2c
+      - const: andestech,atciic100
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c@30800000 {
+        compatible = "andestech,qilai-i2c","andestech,atciic100";
+        reg = <0x30800000 0x100000>;
+        interrupts = <6 IRQ_TYPE_LEVEL_HIGH>;
+    };
-- 
2.34.1
Re: [PATCH 1/4] dt-bindings: i2c: add support for Andes I2C controller
Posted by Krzysztof Kozlowski 3 weeks, 2 days ago
On Thu, Jan 15, 2026 at 10:52:41PM +0800, Ben Zong-You Xie wrote:
> Document device tree bindings for Andes I2C controller.
> 
> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
> ---
>  .../bindings/i2c/andestech,atciic100.yaml     | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
> new file mode 100644
> index 000000000000..dcbcafc8d6bd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/andestech,atciic100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes I2C controller on QiLai SoC and AE350 platform
> +
> +maintainers:
> +  - Ben Zong-You Xie <ben717@andestech.com>

You already sent it and you received review, so I am not going to do the
same work twice.

Version your patches correctly and provide detailed changelog with
rationale of changes.

b4 helps here a lot and you should be using it if all this process is a
bit too complicated.

Best regards,
Krzysztof