[v1] block: remove the boring judgment in blk_rq_map_bio_alloc()

[PATCH] block: remove the boring judgment in blk_rq_map_bio_alloc()

Posted by Chaohai Chen 3 weeks, 3 days ago

There is no need to check the return value of bio_alloc_bioset().

Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
---
 block/blk-map.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/block/blk-map.c b/block/blk-map.c
index 4533094d9458..f95b07ec3b88 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -46,14 +46,8 @@ static struct bio *blk_rq_map_bio_alloc(struct request *rq,
 		unsigned int nr_vecs, gfp_t gfp_mask)
 {
 	struct block_device *bdev = rq->q->disk ? rq->q->disk->part0 : NULL;
-	struct bio *bio;
 
-	bio = bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask,
-				&fs_bio_set);
-	if (!bio)
-		return NULL;
-
-	return bio;
+	return bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask, &fs_bio_set);
 }
 
 /**
-- 
2.43.7

Re: [PATCH] block: remove the boring judgment in blk_rq_map_bio_alloc()

Posted by Jens Axboe 3 weeks, 2 days ago

On 1/15/26 4:43 AM, Chaohai Chen wrote:
> There is no need to check the return value of bio_alloc_bioset().

Boring judgement? I'm very confused, what on earth does that mean.

> diff --git a/block/blk-map.c b/block/blk-map.c
> index 4533094d9458..f95b07ec3b88 100644
> --- a/block/blk-map.c
> +++ b/block/blk-map.c
> @@ -46,14 +46,8 @@ static struct bio *blk_rq_map_bio_alloc(struct request *rq,
>  		unsigned int nr_vecs, gfp_t gfp_mask)
>  {
>  	struct block_device *bdev = rq->q->disk ? rq->q->disk->part0 : NULL;
> -	struct bio *bio;
>  
> -	bio = bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask,
> -				&fs_bio_set);
> -	if (!bio)
> -		return NULL;
> -
> -	return bio;
> +	return bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask, &fs_bio_set);
>  }

Presumably this means that nobody ever calls blk_rq_map_bio_alloc()
without __GFP_WAIT set in gfp_mask? Because otherwise this would be
broken. And this then further means that this should most likely be
checked.

All of this is absent from the commit message, which has zero details.

-- 
Jens Axboe