[v2] mm: balloon infrastructure cleanups

[PATCH v2 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h

Posted by David Hildenbrand (Red Hat) 3 weeks, 4 days ago

Ever since commit 68f2736a8583 ("mm: Convert all PageMovable users to
movable_operations") we no longer store an inode in balloon_dev_info,
so we can stop including "fs.h".

Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>
---
 include/linux/balloon_compaction.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
index 7db66c2c86cdc..1452ea0635245 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -42,7 +42,6 @@
 #include <linux/migrate.h>
 #include <linux/gfp.h>
 #include <linux/err.h>
-#include <linux/fs.h>
 #include <linux/list.h>
 
 /*
-- 
2.52.0

Re: [PATCH v2 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h

Posted by Lorenzo Stoakes 3 weeks, 4 days ago

On Thu, Jan 15, 2026 at 10:20:00AM +0100, David Hildenbrand (Red Hat) wrote:
> Ever since commit 68f2736a8583 ("mm: Convert all PageMovable users to
> movable_operations") we no longer store an inode in balloon_dev_info,
> so we can stop including "fs.h".
>
> Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>

This is a shocking, awful, horrifyingly massive change but reluctantly... only
kidding ;)

Yeah seems sensible so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  include/linux/balloon_compaction.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index 7db66c2c86cdc..1452ea0635245 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -42,7 +42,6 @@
>  #include <linux/migrate.h>
>  #include <linux/gfp.h>
>  #include <linux/err.h>
> -#include <linux/fs.h>
>  #include <linux/list.h>
>
>  /*
> --
> 2.52.0
>