[PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

Sherry Sun posted 3 patches 3 weeks, 2 days ago
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi          | 1 -
arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts     | 1 -
arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts          | 1 -
arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts  | 1 -
5 files changed, 10 deletions(-)
[PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property
Posted by Sherry Sun 3 weeks, 2 days ago
Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.

Let's remove this deprecated property in imx6* dts and the
corresponding dt-binding.

Sherry Sun (3):
  ARM: dts: imx6q-apalis: Remove the deprecated "reset-gpio-active-high"
    property
  ARM: dts: imx6sx-softing-vining-2000: Remove the deprecated
    "reset-gpio-active-high" property
  dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated
    "reset-gpio-active-high" property

 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi          | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts     | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts          | 1 -
 arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts  | 1 -
 5 files changed, 10 deletions(-)

-- 
2.37.1
Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property
Posted by Francesco Dolcini 3 weeks, 2 days ago
On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:
> Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
> deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
> the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.
> 
> Let's remove this deprecated property in imx6* dts and the
> corresponding dt-binding.

Are you sure this is not breaking anything?
DT files from the Linux repository are not used just in Linux.

And , the property is still handled, see commit b8b80348c57b
("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
DT compatibility was not broken as you seem to imply in this series.

Francesco
Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property
Posted by Andy Shevchenko 3 weeks, 2 days ago
On Thu, Jan 15, 2026 at 08:34:18AM +0100, Francesco Dolcini wrote:
> On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:

...

> And , the property is still handled, see commit b8b80348c57b
> ("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
> DT compatibility was not broken as you seem to imply in this series.

This is a quirk and not a 1st class support. There must be no such property
in new DTs, it's only present for the backward compatibility.

For the old ones, indeed the property is needed. The problem of reuse of Linux
DTs somewhere else is orthogonal to the Linux kernel. If this is a real problem
the DTs should have been maintained outside of Linux kernel and, if needed, be
synchronised from time to time.

TL;DR: we must discourage people to use deprecated and (historically) wrong
properties.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property
Posted by Francesco Dolcini 3 weeks, 2 days ago
On Thu, Jan 15, 2026 at 10:08:47AM +0200, Andy Shevchenko wrote:
> On Thu, Jan 15, 2026 at 08:34:18AM +0100, Francesco Dolcini wrote:
> > On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:
> 
> ...
> 
> > And , the property is still handled, see commit b8b80348c57b
> > ("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
> > DT compatibility was not broken as you seem to imply in this series.
> 
> This is a quirk and not a 1st class support. There must be no such property
> in new DTs, it's only present for the backward compatibility.
> 
> For the old ones, indeed the property is needed.

Ack, we just agree here.

Francesco