The platform_get_irq_byname() function already prints an error message
internally upon failure using dev_err_probe(). Therefore, the explicit
dev_err() is redundant and results in duplicate error logs.

Remove the redundant dev_err() call to clean up the error path.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
index 43b834459ccf..ab8f7f6f3be1 100644
--- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
+++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
@@ -868,7 +868,6 @@ static int mali_c55_probe(struct platform_device *pdev)
 	mali_c55->irqnum = platform_get_irq(pdev, 0);
 	if (mali_c55->irqnum < 0) {
 		ret = mali_c55->irqnum;
-		dev_err(dev, "failed to get interrupt\n");
 		goto err_deinit_media_frameworks;
 	}
 
-- 
2.25.1

Hi Chen

On Thu, Jan 15, 2026 at 10:35:16AM +0800, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
>
> Remove the redundant dev_err() call to clean up the error path.
>

Indeed

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..ab8f7f6f3be1 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -868,7 +868,6 @@ static int mali_c55_probe(struct platform_device *pdev)
>  	mali_c55->irqnum = platform_get_irq(pdev, 0);
>  	if (mali_c55->irqnum < 0) {
>  		ret = mali_c55->irqnum;
> -		dev_err(dev, "failed to get interrupt\n");
>  		goto err_deinit_media_frameworks;
>  	}
>
> --
> 2.25.1
>

Hi Chen - thanks for the patch

On 15/01/2026 02:35, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
> 
> Remove the redundant dev_err() call to clean up the error path.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
>   drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..ab8f7f6f3be1 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -868,7 +868,6 @@ static int mali_c55_probe(struct platform_device *pdev)
>   	mali_c55->irqnum = platform_get_irq(pdev, 0);
>   	if (mali_c55->irqnum < 0) {
>   		ret = mali_c55->irqnum;
> -		dev_err(dev, "failed to get interrupt\n");
>   		goto err_deinit_media_frameworks;
>   	}
>