scripts: generate_rust_analyzer: compile quote with correct edition

[PATCH] scripts: generate_rust_analyzer: compile quote with correct edition

Posted by Tamir Duberstein 3 weeks, 2 days ago

From: Tamir Duberstein <tamird@gmail.com>

Our copy of the quote crate uses edition 2018, thus generate the correct
rust-analyzer configuration for it.

Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 scripts/generate_rust_analyzer.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
index 6061bd6e2ebd..c6a1f1660c0d 100755
--- a/scripts/generate_rust_analyzer.py
+++ b/scripts/generate_rust_analyzer.py
@@ -98,6 +98,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
         srctree / "rust" / "quote" / "lib.rs",
         ["alloc", "proc_macro", "proc_macro2"],
         cfg=crates_cfgs["quote"],
+        edition="2018",
     )
 
     append_crate(

---
base-commit: 74e15ac34b098934895fd27655d098971d2b43d9
change-id: 20260115-rust-analyzer-quote-edition-bf00e950f179

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition

Posted by Miguel Ojeda 2 weeks, 6 days ago

On Thu, Jan 15, 2026 at 5:46 PM Tamir Duberstein <tamird@kernel.org> wrote:
>
> From: Tamir Duberstein <tamird@gmail.com>
>
> Our copy of the quote crate uses edition 2018, thus generate the correct
> rust-analyzer configuration for it.
>
> Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Applied to `rust-fixes` -- thanks everyone!

Cheers,
Miguel

Re: [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition

Posted by Gary Guo 3 weeks, 1 day ago

On Thu Jan 15, 2026 at 4:45 PM GMT, Tamir Duberstein wrote:
> From: Tamir Duberstein <tamird@gmail.com>
> 
> Our copy of the quote crate uses edition 2018, thus generate the correct
> rust-analyzer configuration for it.
> 
> Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  scripts/generate_rust_analyzer.py | 1 +
>  1 file changed, 1 insertion(+)

Re: [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition

Posted by Jesung Yang 3 weeks, 1 day ago

On Fri Jan 16, 2026 at 1:45 AM KST, Tamir Duberstein wrote:
> From: Tamir Duberstein <tamird@gmail.com>
>
> Our copy of the quote crate uses edition 2018, thus generate the correct
> rust-analyzer configuration for it.
>
> Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Jesung Yang <y.j3ms.n@gmail.com>

Best regards,
Jesung

> ---
>  scripts/generate_rust_analyzer.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 6061bd6e2ebd..c6a1f1660c0d 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -98,6 +98,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
>          srctree / "rust" / "quote" / "lib.rs",
>          ["alloc", "proc_macro", "proc_macro2"],
>          cfg=crates_cfgs["quote"],
> +        edition="2018",
>      )
>  
>      append_crate(
>
> ---
> base-commit: 74e15ac34b098934895fd27655d098971d2b43d9
> change-id: 20260115-rust-analyzer-quote-edition-bf00e950f179
>
> Best regards,
> --  
> Tamir Duberstein <tamird@gmail.com>

Re: [PATCH] scripts: generate_rust_analyzer: compile quote with correct edition

Posted by Miguel Ojeda 3 weeks, 2 days ago

On Thu, Jan 15, 2026 at 5:46 PM Tamir Duberstein <tamird@kernel.org> wrote:
>
> Our copy of the quote crate uses edition 2018, thus generate the correct
> rust-analyzer configuration for it.
>
> Fixes: 88de91cc1ce7 ("rust: quote: enable support in kbuild")
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Cc'ing Jesung who is becoming a reviewer for rust-analyzer.

Thanks!

Cheers,
Miguel