[v1] i3c: dw: Initialize spinlock to avoid upsetting lockdep

[PATCH] i3c: dw: Initialize spinlock to avoid upsetting lockdep

Posted by Fredrik Markstrom via B4 Relay 3 weeks, 3 days ago

From: Fredrik Markstrom <fredrik.markstrom@est.tech>

Fixes: e389b1d72a624 ("i3c: dw: Add support for in-band interrupts")
Suggested-by: Jani Nurminen <jani.nurminen@windriver.com>
Signed-off-by: Fredrik Markstrom <fredrik.markstrom@est.tech>
Reviewed-by: Ivar Holmqvist <ivar.holmqvist@est.tech>
---
 drivers/i3c/master/dw-i3c-master.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 889e2ed5bc83..d5b070404056 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1570,6 +1570,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
 	spin_lock_init(&master->xferqueue.lock);
 	INIT_LIST_HEAD(&master->xferqueue.list);
 
+	spin_lock_init(&master->devs_lock);
+
 	writel(INTR_ALL, master->regs + INTR_STATUS);
 	irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, irq,

---
base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
change-id: 20260115-i3c_dw_initialize_spinlock-d878212a846b

Best regards,
-- 
Fredrik Markstrom <fredrik.markstrom@est.tech>

Re: [PATCH] i3c: dw: Initialize spinlock to avoid upsetting lockdep

Posted by Frank Li 3 weeks, 3 days ago

On Thu, Jan 15, 2026 at 02:25:29PM +0100, Fredrik Markstrom wrote:

Need context here. You can duplicate subject.

Initialize spinlock to avoid upsetting lockdep.

Frank

> Fixes: e389b1d72a624 ("i3c: dw: Add support for in-band interrupts")
> Suggested-by: Jani Nurminen <jani.nurminen@windriver.com>
> Signed-off-by: Fredrik Markstrom <fredrik.markstrom@est.tech>
> Reviewed-by: Ivar Holmqvist <ivar.holmqvist@est.tech>
> ---
>  drivers/i3c/master/dw-i3c-master.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 889e2ed5bc83..d5b070404056 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1570,6 +1570,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>  	spin_lock_init(&master->xferqueue.lock);
>  	INIT_LIST_HEAD(&master->xferqueue.list);
>
> +	spin_lock_init(&master->devs_lock);
> +
>  	writel(INTR_ALL, master->regs + INTR_STATUS);
>  	irq = platform_get_irq(pdev, 0);
>  	ret = devm_request_irq(&pdev->dev, irq,
>
> ---
> base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
> change-id: 20260115-i3c_dw_initialize_spinlock-d878212a846b
>
> Best regards,
> --
> Fredrik Markstrom <fredrik.markstrom@est.tech>
>