kbuild: Fix unnecessary rebuilding DT base+overlay targets

[PATCH] kbuild: Fix unnecessary rebuilding DT base+overlay targets

Posted by Rob Herring (Arm) 3 weeks, 3 days ago

Commit 5d0cac427d42 ("kbuild: Support directory targets for building
DTBs") causes base+overlay targets to be rebuilt every time. The problem
is due to the added check on $(MAKECMDGOALS) which now testing again
doesn't even seem to be needed. Revert that portion of the commit.

Fixes: 5d0cac427d42 ("kbuild: Support directory targets for building DTBs")
Reported-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 scripts/Makefile.dtbs | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/scripts/Makefile.dtbs b/scripts/Makefile.dtbs
index f5d51b8c2eeb..b2d85b9a4a7a 100644
--- a/scripts/Makefile.dtbs
+++ b/scripts/Makefile.dtbs
@@ -23,10 +23,7 @@ dtb-y           := $(addprefix $(obj)/, $(dtb-y))
 multi-dtb-y     := $(addprefix $(obj)/, $(multi-dtb-y))
 real-dtb-y      := $(addprefix $(obj)/, $(real-dtb-y))
 
-dtb-targets := %.dtb %.dtbo dtbs dtbs_check
-ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)
 always-y        += $(dtb-y)
-endif
 
 targets         += $(real-dtb-y)
 
-- 
2.51.0

Re: [PATCH] kbuild: Fix unnecessary rebuilding DT base+overlay targets

Posted by David Heidelberg 3 weeks, 3 days ago

On 14/01/2026 19:46, Rob Herring (Arm) wrote:
> Commit 5d0cac427d42 ("kbuild: Support directory targets for building
> DTBs") causes base+overlay targets to be rebuilt every time. The problem
> is due to the added check on $(MAKECMDGOALS) which now testing again
> doesn't even seem to be needed. Revert that portion of the commit.
> 
> Fixes: 5d0cac427d42 ("kbuild: Support directory targets for building DTBs")
> Reported-by: David Heidelberg <david@ixit.cz>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   scripts/Makefile.dtbs | 3 ---
>   1 file changed, 3 deletions(-)
> 

Whoa, that was quick! Thanks.

Tested-by: David Heidelberg <david@ixit.cz>