mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary

[PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary

Posted by hehuan1@eswincomputing.com 3 weeks, 3 days ago

From: Huan He <hehuan1@eswincomputing.com>

This DWC MSHC has a 128MB limitation where the data buffer size and start
address must not exceed the 128MB boundary. Registering the missing
'adma_write_desc' callback function.

Signed-off-by: Huan He <hehuan1@eswincomputing.com>
---
 drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 51949cde0958..cabb709a8108 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
 	.set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
 	.set_power = sdhci_set_power_and_bus_voltage,
 	.irq = dwcmshc_cqe_irq_handler,
+	.adma_write_desc = dwcmshc_adma_write_desc,
 	.platform_execute_tuning = sdhci_eic7700_executing_tuning,
 };
 
-- 
2.25.1

Re: [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary

Posted by Ulf Hansson 2 weeks, 2 days ago

On Wed, 14 Jan 2026 at 13:23, <hehuan1@eswincomputing.com> wrote:
>
> From: Huan He <hehuan1@eswincomputing.com>
>
> This DWC MSHC has a 128MB limitation where the data buffer size and start
> address must not exceed the 128MB boundary. Registering the missing
> 'adma_write_desc' callback function.
>
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>

Applied for fixes and by adding a fixes tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 51949cde0958..cabb709a8108 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
>         .set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
>         .set_power = sdhci_set_power_and_bus_voltage,
>         .irq = dwcmshc_cqe_irq_handler,
> +       .adma_write_desc = dwcmshc_adma_write_desc,
>         .platform_execute_tuning = sdhci_eic7700_executing_tuning,
>  };
>
> --
> 2.25.1
>

Re: [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary

Posted by Adrian Hunter 2 weeks, 3 days ago

On 14/01/2026 14:22, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
> 
> This DWC MSHC has a 128MB limitation where the data buffer size and start
> address must not exceed the 128MB boundary. Registering the missing
> 'adma_write_desc' callback function.
> 
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>

Fixes tag?

Nevertheless:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 51949cde0958..cabb709a8108 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
>  	.set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
>  	.set_power = sdhci_set_power_and_bus_voltage,
>  	.irq = dwcmshc_cqe_irq_handler,
> +	.adma_write_desc = dwcmshc_adma_write_desc,
>  	.platform_execute_tuning = sdhci_eic7700_executing_tuning,
>  };
>