[PATCH v5 29/68] ksmbd_vfs_rename(): vfs_path_parent_lookup() accepts ERR_PTR() as name

no need to check in the caller

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/smb/server/vfs.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index a97226116840..30b65b667b96 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -674,10 +674,6 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path,
 		return -ENOMEM;
 
 	to = getname_kernel(newname);
-	if (IS_ERR(to)) {
-		err = PTR_ERR(to);
-		goto revert_fsids;
-	}
 
 retry:
 	err = vfs_path_parent_lookup(to, lookup_flags | LOOKUP_BENEATH,
@@ -737,7 +733,6 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path,
 	}
 out1:
 	putname(to);
-revert_fsids:
 	ksmbd_revert_fsids(work);
 	return err;
 }
-- 
2.47.3

• [PATCH v5 01/68] init_mknod(): turn into a trivial wrapper for do_mknodat()
• [PATCH v5 02/68] init_mkdir(): turn into a trivial wrapper for do_mkdirat()
• [PATCH v5 03/68] init_symlink(): turn into a trivial wrapper for do_symlinkat()
• [PATCH v5 04/68] init_link(): turn into a trivial wrapper for do_linkat()
• [PATCH v5 05/68] allow to use CLASS() for struct filename *
• [PATCH v5 06/68] do_faccessat(): import pathname only once
• [PATCH v5 07/68] do_fchmodat(): import pathname only once
• [PATCH v5 08/68] do_fchownat(): import pathname only once
• [PATCH v5 09/68] do_utimes_path(): import pathname only once
• [PATCH v5 10/68] chdir(2): import pathname only once
• [PATCH v5 11/68] chroot(2): import pathname only once
• [PATCH v5 12/68] user_statfs(): import pathname only once
• [PATCH v5 13/68] do_sys_truncate(): import pathname only once
• [PATCH v5 14/68] do_readlinkat(): import pathname only once
• [PATCH v5 15/68] get rid of audit_reusename()
• [PATCH v5 16/68] ntfs: ->d_compare() must not block
• [PATCH v5 17/68] getname_flags() massage, part 1
• [PATCH v5 18/68] getname_flags() massage, part 2
• [PATCH v5 19/68] struct filename: use names_cachep only for getname() and friends
• [PATCH v5 20/68] struct filename: saner handling of long names
• [PATCH v5 21/68] fs: hide names_cache behind runtime const machinery
• [PATCH v5 22/68] switch __getname_maybe_null() to CLASS(filename_flags)
• [PATCH v5 23/68] allow incomplete imports of filenames
• [PATCH v5 24/68] struct filename ->refcnt doesn't need to be atomic
• [PATCH v5 25/68] file_getattr(): filename_lookup() accepts ERR_PTR() as filename
• [PATCH v5 26/68] file_setattr(): filename_lookup() accepts ERR_PTR() as filename
• [PATCH v5 27/68] move_mount(): filename_lookup() accepts ERR_PTR() as filename
• [PATCH v5 28/68] ksmbd_vfs_path_lookup(): vfs_path_parent_lookup() accepts ERR_PTR() as name
• [PATCH v5 29/68] ksmbd_vfs_rename(): vfs_path_parent_lookup() accepts ERR_PTR() as name
• [PATCH v5 30/68] do_filp_open(): DTRT when getting ERR_PTR() as pathname
• [PATCH v5 31/68] rename do_filp_open() to do_file_open()
• [PATCH v5 32/68] do_sys_openat2(): get rid of useless check, switch to CLASS(filename)
• [PATCH v5 33/68] simplify the callers of file_open_name()
• [PATCH v5 34/68] simplify the callers of do_open_execat()
• [PATCH v5 35/68] simplify the callers of alloc_bprm()
• [PATCH v5 36/68] execve: fold {compat_,}do_execve{,at}() into their sole callers
• [PATCH v5 37/68] do_execveat_common(): don't consume filename reference
• [PATCH v5 38/68] switch {alloc,free}_bprm() to CLASS()
• [PATCH v5 39/68] non-consuming variant of do_renameat2()
• [PATCH v5 40/68] non-consuming variant of do_linkat()
• [PATCH v5 41/68] non-consuming variant of do_symlinkat()
• [PATCH v5 42/68] non-consuming variant of do_mkdirat()
• [PATCH v5 43/68] non-consuming variant of do_mknodat()
• [PATCH v5 44/68] non-consuming variants of do_{unlinkat,rmdir}()
• [PATCH v5 45/68] file_[gs]etattr(2): switch to CLASS(filename_maybe_null)
• [PATCH v5 46/68] mount_setattr(2): don't mess with LOOKUP_EMPTY
• [PATCH v5 47/68] do_open_execat(): don't care about LOOKUP_EMPTY
• [PATCH v5 48/68] vfs_open_tree(): use CLASS(filename_uflags)
• [PATCH v5 49/68] name_to_handle_at(): use CLASS(filename_uflags)
• [PATCH v5 50/68] fspick(2): use CLASS(filename_flags)
• [PATCH v5 51/68] do_fchownat(): unspaghettify a bit...
• [PATCH v5 52/68] chdir(2): unspaghettify a bit...
• [PATCH v5 53/68] do_utimes_path(): switch to CLASS(filename_uflags)
• [PATCH v5 54/68] do_sys_truncate(): switch to CLASS(filename)
• [PATCH v5 55/68] do_readlinkat(): switch to CLASS(filename_flags)
• [PATCH v5 56/68] do_f{chmod,chown,access}at(): use CLASS(filename_uflags)
• [PATCH v5 57/68] namei.c: convert getname_kernel() callers to CLASS(filename_kernel)
• [PATCH v5 58/68] namei.c: switch user pathname imports to CLASS(filename{,_flags})
• [PATCH v5 59/68] filename_...xattr(): don't consume filename reference
• [PATCH v5 60/68] move_mount(2): switch to CLASS(filename_maybe_null)
• [PATCH v5 61/68] chroot(2): switch to CLASS(filename)
• [PATCH v5 62/68] quotactl_block(): switch to CLASS(filename)
• [PATCH v5 63/68] statx: switch to CLASS(filename_maybe_null)
• [PATCH v5 64/68] user_statfs(): switch to CLASS(filename)
• [PATCH v5 65/68] mqueue: switch to CLASS(filename)
• [PATCH v5 66/68] ksmbd: use CLASS(filename_kernel)
• [PATCH v5 67/68] alpha: switch osf_mount() to strndup_user()
• [PATCH v5 68/68] sysfs(2): fs_index() argument is _not_ a pathname