1. Patchew
  2. linux
  3. [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board
  4. View patch

[PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

Haibo Chen posted 3 patches 3 weeks, 5 days ago
[PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Haibo Chen 3 weeks, 5 days ago 
Document i.MX952 XSPI compatible, which is derived from
i.MX94 XSPI.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
--- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
+++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
@@ -15,6 +15,10 @@ properties:
     oneOf:
       - enum:
           - nxp,imx94-xspi
+      - items:
+          - enum:
+              - nxp,imx952-xspi
+          - const: nxp,imx94-xspi
 
   reg:
     items:

-- 
2.34.1
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Krzysztof Kozlowski 3 weeks, 3 days ago 
On 14/01/2026 07:49, Haibo Chen wrote:
> Document i.MX952 XSPI compatible, which is derived from
> i.MX94 XSPI.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>  1 file changed, 4 insertions(+)



Best regards,
Krzysztof
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Frank Li 3 weeks, 3 days ago 
On Thu, Jan 15, 2026 at 09:55:57PM +0100, Krzysztof Kozlowski wrote:
> On 14/01/2026 07:49, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
>

Krzysztof:

	You sent an empty message here.

Frank
>
>
> Best regards,
> Krzysztof
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Krzysztof Kozlowski 1 day, 10 hours ago 
On 15/01/2026 22:07, Frank Li wrote:
> On Thu, Jan 15, 2026 at 09:55:57PM +0100, Krzysztof Kozlowski wrote:
>> On 14/01/2026 07:49, Haibo Chen wrote:
>>> Document i.MX952 XSPI compatible, which is derived from
>>> i.MX94 XSPI.
>>>
>>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>> ---
>>>  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>
> 
> Krzysztof:
> 
> 	You sent an empty message here.
> 
> Frank
>>

Thanks, second try:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Krzysztof Kozlowski 3 weeks, 4 days ago 
On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> Document i.MX952 XSPI compatible, which is derived from
> i.MX94 XSPI.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> @@ -15,6 +15,10 @@ properties:
>      oneOf:
>        - enum:
>            - nxp,imx94-xspi
> +      - items:
> +          - enum:
> +              - nxp,imx952-xspi
> +          - const: nxp,imx94-xspi

You never checked your DTS and broke all existing users. And existing
tools would clearly tell you that if you tried.

Use tools instead of reviewers. Reviewers time is more important, so if
you just disregard it I find it quite disrespectful.

Best regards,
Krzysztof
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Frank Li 3 weeks, 4 days ago 
On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> >      oneOf:
> >        - enum:
> >            - nxp,imx94-xspi
> > +      - items:
> > +          - enum:
> > +              - nxp,imx952-xspi
> > +          - const: nxp,imx94-xspi
>
> You never checked your DTS and broke all existing users. And existing
> tools would clearly tell you that if you tried.

Krzysztof:

	what's wrong?

	I have not find any warnings under arch/arm64/boot/dts/freescale by

	make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs

Frank
>
> Use tools instead of reviewers. Reviewers time is more important, so if
> you just disregard it I find it quite disrespectful.
>
> Best regards,
> Krzysztof
>
Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Posted by Krzysztof Kozlowski 3 weeks, 3 days ago 
On 15/01/2026 16:15, Frank Li wrote:
> On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
>> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
>>> Document i.MX952 XSPI compatible, which is derived from
>>> i.MX94 XSPI.
>>>
>>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>> ---
>>>  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
>>> --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> @@ -15,6 +15,10 @@ properties:
>>>      oneOf:
>>>        - enum:
>>>            - nxp,imx94-xspi
>>> +      - items:
>>> +          - enum:
>>> +              - nxp,imx952-xspi
>>> +          - const: nxp,imx94-xspi
>>
>> You never checked your DTS and broke all existing users. And existing
>> tools would clearly tell you that if you tried.
> 
> Krzysztof:
> 
> 	what's wrong?
> 
> 	I have not find any warnings under arch/arm64/boot/dts/freescale by
> 
> 	make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs

I misread the diff context and patch is obviously fine. Thanks for
correcting me.


Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.