[PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag

Petre Rodan posted 13 patches 3 weeks, 5 days ago
[PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag
Posted by Petre Rodan 3 weeks, 5 days ago
Interrupt falling/rising flags should only be defined in the device tree.

Fixes: 713337d9143e ("iio: pressure: Honeywell mprls0025pa pressure sensor")
Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
v1 -> v2 use IRQF_TRIGGER_NONE as Jonathan requested
v2 -> v3 use 0 instead of IRQF_TRIGGER_NONE as per Andy's request
---
 drivers/iio/pressure/mprls0025pa.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/pressure/mprls0025pa.c b/drivers/iio/pressure/mprls0025pa.c
index 2336f2760eae..4b23f87a822b 100644
--- a/drivers/iio/pressure/mprls0025pa.c
+++ b/drivers/iio/pressure/mprls0025pa.c
@@ -418,10 +418,8 @@ int mpr_common_probe(struct device *dev, const struct mpr_ops *ops, int irq)
 	data->offset = div_s64_rem(offset, NANO, &data->offset2);
 
 	if (data->irq > 0) {
-		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
-				       IRQF_TRIGGER_RISING,
-				       dev_name(dev),
-				       data);
+		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, 0,
+				       dev_name(dev), data);
 		if (ret)
 			return dev_err_probe(dev, ret,
 					  "request irq %d failed\n", data->irq);

-- 
2.52.0
Re: [PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag
Posted by Andy Shevchenko 3 weeks, 5 days ago
On Wed, Jan 14, 2026 at 06:55:32PM +0200, Petre Rodan wrote:
> Interrupt falling/rising flags should only be defined in the device tree.

...

>  	if (data->irq > 0) {
> -		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> -				       IRQF_TRIGGER_RISING,
> -				       dev_name(dev),
> -				       data);
> +		ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, 0,
> +				       dev_name(dev), data);
>  		if (ret)

>  			return dev_err_probe(dev, ret,
>  					  "request irq %d failed\n", data->irq);

Also drop this (in a separate change?) as devm_request_*irq*() prints the
similar one.

-- 
With Best Regards,
Andy Shevchenko