Devicetree bindings for MAX22007 4-channel
12-bit DAC that drives a voltage or current
output on each channel
Signed-off-by: Janani Sunil <janani.sunil@analog.com>
---
.../devicetree/bindings/iio/dac/adi,max22007.yaml | 116 +++++++++++++++++++++
MAINTAINERS | 15 +++
2 files changed, 131 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
new file mode 100644
index 000000000000..c2f65d9e42d4
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
@@ -0,0 +1,116 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/adi,max22007.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX22007 DAC device driver
+
+maintainers:
+ - Janani Sunil <janani.sunil@analog.com>
+
+description:
+ The MAX22007 is a quad-channel, 12-bit digital-to-analog converter (DAC)
+ with integrated precision output amplifiers and current output capability.
+ Each channel can be independently configured for voltage or current output.
+ Datasheet available at https://www.analog.com/en/products/max22007.html
+
+$ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: adi,max22007
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 500000
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+ vdd-supply:
+ description: Low-Voltage Power Supply from +2.7V to +5.5V.
+
+ hvdd-supply:
+ description:
+ Positive High-Voltage Power Supply from +8V to (HVSS +24V) for
+ the Output Channels.
+
+ hvss-supply:
+ description:
+ Negative High-Voltage Power Supply from -2V to 0V for the Output Channels.
+
+ reset-gpios:
+ maxItems: 1
+ description:
+ GPIO used for hardware reset of the device.
+
+patternProperties:
+ "^channel@[0-3]$":
+ allOf:
+ - $ref: /schemas/iio/dac/dac.yaml#
+ - type: object
+ description:
+ Represents the external channels which are connected to the DAC.
+ Channels not specified in the device tree will be powered off.
+
+ properties:
+ reg:
+ description: Channel number
+ maxItems: 1
+
+ adi,type:
+ description: Channel output type.
+ $ref: /schemas/types.yaml#/definitions/string
+ enum: [voltage, current]
+
+ required:
+ - reg
+ - adi,type
+
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+
+anyOf:
+ - required: [channel@0]
+ - required: [channel@1]
+ - required: [channel@2]
+ - required: [channel@3]
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dac@0 {
+ compatible = "adi,max22007";
+ reg = <0>;
+ spi-max-frequency = <500000>;
+ reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel@0 {
+ reg = <0>;
+ adi,type = "voltage";
+ };
+
+ channel@1 {
+ reg = <1>;
+ adi,type = "current";
+ };
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b11839cba9d..c378d4b8f5ae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1594,6 +1594,21 @@ W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml
F: drivers/iio/dac/ad9739a.c
+ANALOG DEVICES INC AD8460 DRIVER
+M: Mariel Tinaco <Mariel.Tinaco@analog.com>
+L: linux-iio@vger.kernel.org
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml
+F: drivers/iio/dac/ad8460.c
+
+ANALOG DEVICES INC MAX22007 DRIVER
+M: Janani Sunil <janani.sunil@analog.com>
+L: linux-iio@vger.kernel.org
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
+
ANALOG DEVICES INC ADA4250 DRIVER
M: Antoniu Miclaus <antoniu.miclaus@analog.com>
L: linux-iio@vger.kernel.org
--
2.43.0On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote: > Devicetree bindings for MAX22007 4-channel > 12-bit DAC that drives a voltage or current > output on each channel What is happening with this patchset - why are you making somehow unrelated, different, unexpected and incorrect changes like ones above? You are supposed to work with Git e.g. on dedicated branch, so you clearly see what you did. Why doing such changes? > > Signed-off-by: Janani Sunil <janani.sunil@analog.com> > --- > .../devicetree/bindings/iio/dac/adi,max22007.yaml | 116 +++++++++++++++++++++ > MAINTAINERS | 15 +++ > 2 files changed, 131 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml > new file mode 100644 > index 000000000000..c2f65d9e42d4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,max22007.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX22007 DAC device driver Why did you changed this? What else changed? Nothing about this was mentioned in the changelog. I finished the review here. Please be concious what you are changing, do not introduce random changes and then write correct changelogs describing what you did. You already received review which you SILENTLY ignored. That is not acceptable, either. You MUST provide reasons! Now, that review is invalidated anyway. > diff --git a/MAINTAINERS b/MAINTAINERS > index 5b11839cba9d..c378d4b8f5ae 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1594,6 +1594,21 @@ W: https://ez.analog.com/linux-software-drivers > F: Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml > F: drivers/iio/dac/ad9739a.c > > +ANALOG DEVICES INC AD8460 DRIVER > +M: Mariel Tinaco <Mariel.Tinaco@analog.com> > +L: linux-iio@vger.kernel.org > +S: Supported > +W: https://ez.analog.com/linux-software-drivers > +F: Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml > +F: drivers/iio/dac/ad8460.c What? NAK
Hi Krzysztof, On 1/15/26 10:24, Krzysztof Kozlowski wrote: > On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote: >> Devicetree bindings for MAX22007 4-channel >> 12-bit DAC that drives a voltage or current >> output on each channel > What is happening with this patchset - why are you making somehow > unrelated, different, unexpected and incorrect changes like ones above? > > You are supposed to work with Git e.g. on dedicated branch, so you > clearly see what you did. Why doing such changes? Apologies for the confusion- this was my mistake. I picked up V1 of the patch by accident. I'll rework it to address the incorrect changes and will resend the corrected version. Regards, Janani Sunil
On 15/01/2026 11:24, Janani Sunil wrote: > Hi Krzysztof, > > On 1/15/26 10:24, Krzysztof Kozlowski wrote: >> On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote: >>> Devicetree bindings for MAX22007 4-channel >>> 12-bit DAC that drives a voltage or current >>> output on each channel >> What is happening with this patchset - why are you making somehow >> unrelated, different, unexpected and incorrect changes like ones above? >> >> You are supposed to work with Git e.g. on dedicated branch, so you >> clearly see what you did. Why doing such changes? > > Apologies for the confusion- this was my mistake. > > I picked up V1 of the patch by accident. I'll rework it to address the incorrect changes and will resend the corrected version. How "picked"? You are supposed to have them in your git, on your dedicated git branch for example. They cannot be "picked" or "unpicked" because they are already there and you only add incremental changes which you squash or commit amend. Really proficiency of Git is absolute basic in kernel development. Best regards, Krzysztof
On 15/01/2026 10:24, Krzysztof Kozlowski wrote: > On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote: >> Devicetree bindings for MAX22007 4-channel >> 12-bit DAC that drives a voltage or current >> output on each channel > > What is happening with this patchset - why are you making somehow > unrelated, different, unexpected and incorrect changes like ones above? Heh, I already told you that at v1, so you basically ignored my entire feedback from v1 and all the changes at v2. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.