[PATCH v6 2/2] iio: pressure: abp2030pa: remove error message

Petre Rodan posted 2 patches 3 weeks, 6 days ago
[PATCH v6 2/2] iio: pressure: abp2030pa: remove error message
Posted by Petre Rodan 3 weeks, 6 days ago
Do not print redundant error message if devm_request_irq() fails.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
---
 drivers/iio/pressure/abp2030pa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
index be11e28208ec..4ca056a73cef 100644
--- a/drivers/iio/pressure/abp2030pa.c
+++ b/drivers/iio/pressure/abp2030pa.c
@@ -523,7 +523,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
 		ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
 				       dev_name(dev), data);
 		if (ret)
-			return dev_err_probe(dev, ret, "request irq %d failed\n", data->irq);
+			return ret;
 	}
 
 	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,

-- 
2.52.0
Re: [PATCH v6 2/2] iio: pressure: abp2030pa: remove error message
Posted by Andy Shevchenko 3 weeks, 6 days ago
On Wed, Jan 14, 2026 at 9:52 AM Petre Rodan <petre.rodan@subdimension.ro> wrote:
>
> Do not print redundant error message if devm_request_irq() fails.

the duplicate

(It's not redundant, it's duplicate because that API prints something
very similar.)

P.S. Do not send a new version for this, I hope Jonathan can tweak
this small detail whilst applying.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v6 2/2] iio: pressure: abp2030pa: remove error message
Posted by Jonathan Cameron 3 weeks, 6 days ago
On Wed, 14 Jan 2026 09:55:22 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Jan 14, 2026 at 9:52 AM Petre Rodan <petre.rodan@subdimension.ro> wrote:
> >
> > Do not print redundant error message if devm_request_irq() fails.  
> 
> the duplicate
I went with "a duplicate" as it seemed to read better to my ear.

Tweaked and applied.

Thanks,

Jonathan

> 
> (It's not redundant, it's duplicate because that API prints something
> very similar.)
> 
> P.S. Do not send a new version for this, I hope Jonathan can tweak
> this small detail whilst applying.
>