[PATCH v5 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback

Krishna Chomal posted 2 patches 3 weeks, 4 days ago
drivers/platform/x86/hp/hp-wmi.c | 275 ++++++++++++++++++++++++-------
1 file changed, 214 insertions(+), 61 deletions(-)
[PATCH v5 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback
Posted by Krishna Chomal 3 weeks, 4 days ago
This series fixes incorrect thermal profile parameters sent for HP Omen
16-wf1xxx and implements hardware readback support for Victus S thermal
profiles.

The first patch refactors the DMI handling for Victus S boards. By
moving from simple string list to DMI system id table with driver_data,
we can now map each board to its correct thermal parameters.

The second patch implements "get" callback for the platform profile API.
It reads the hardware state from EC register 0x59. This ensures that the
driver stays in sync with the hardware during driver init and power
source change events.

Changes in v5:
- Improved platform_profile_victus_s_get_ec() to support multiple EC
  layouts by iteratively probing offsets.
Changes in v4:
- Fixed driver load failure caused in v3
- Handle err after calling victus_s_gpu_thermal_profile_get()
- Fixed wrong function call victus_s_powersource_event()
Changes in v3:
- Moved DMI lookup to hp_wmi_init()
- Marked DMI table as __initconst
- Renamed `eco` to `low_power`
- Added second patch to implement "get" support for Victus S devices
Changes in v2:
- Refactored victus_s_thermal_profile_boards to use DMI table
- Implemented driver_data to handle thermal profile parameters
- Moved enum definitions earlier in the file for thermal profile
  parameters
Changes in v1:
  Initial fix for Omen 16-wf1xxx thermal profile values

Krishna Chomal (2):
  platform/x86: hp-wmi: fix platform profile values for Omen 16-wf1xxx
  platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profile

 drivers/platform/x86/hp/hp-wmi.c | 275 ++++++++++++++++++++++++-------
 1 file changed, 214 insertions(+), 61 deletions(-)

-- 
2.52.0
Re: [PATCH v5 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback
Posted by Ilpo Järvinen 1 week, 3 days ago
On Tue, 13 Jan 2026 23:56:02 +0530, Krishna Chomal wrote:

> This series fixes incorrect thermal profile parameters sent for HP Omen
> 16-wf1xxx and implements hardware readback support for Victus S thermal
> profiles.
> 
> The first patch refactors the DMI handling for Victus S boards. By
> moving from simple string list to DMI system id table with driver_data,
> we can now map each board to its correct thermal parameters.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profile
      commit: eeeb4c9874bb7ad11d322156443b1d3ebfaaa1cf

--
 i.
Re: [PATCH v5 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback
Posted by Krishna Chomal 1 week ago
On Wed, Jan 28, 2026 at 03:06:20PM +0200, Ilpo Järvinen wrote:
>On Tue, 13 Jan 2026 23:56:02 +0530, Krishna Chomal wrote:
>
>> This series fixes incorrect thermal profile parameters sent for HP Omen
>> 16-wf1xxx and implements hardware readback support for Victus S thermal
>> profiles.
>>
>> The first patch refactors the DMI handling for Victus S boards. By
>> moving from simple string list to DMI system id table with driver_data,
>> we can now map each board to its correct thermal parameters.
>>
>> [...]
>
>
>Thank you for your contribution, it has been applied to my local
>review-ilpo-next branch. Note it will show up in the public
>platform-drivers-x86/review-ilpo-next branch only once I've pushed my
>local branch there, which might take a while.
>
>The list of commits applied:
>[1/1] platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profile
>      commit: eeeb4c9874bb7ad11d322156443b1d3ebfaaa1cf
>
>--
> i.
>

Thank you :)