[v1] perf/x86/amd/ibs: Fix comment typo in ibs_op_data

[PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data

Posted by rrrrr4413@gmail.com 3 weeks, 4 days ago

The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".

This just fixes the misleading comment. No functional changes.

Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
---
 arch/x86/include/asm/amd/ibs.h       | 2 +-
 tools/arch/x86/include/asm/amd/ibs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 3ee5903982c2..7d44881d1a28 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
 	__u64 val;
 	struct {
 		__u64	comp_to_ret_ctr:16,	/* 0-15: op completion to retire count */
-			tag_to_ret_ctr:16,	/* 15-31: op tag to retire count */
+			tag_to_ret_ctr:16,	/* 16-31: op tag to retire count */
 			reserved1:2,		/* 32-33: reserved */
 			op_return:1,		/* 34: return op */
 			op_brn_taken:1,		/* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54fec7b9..25c00000f698 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
 	__u64 val;
 	struct {
 		__u64	comp_to_ret_ctr:16,	/* 0-15: op completion to retire count */
-			tag_to_ret_ctr:16,	/* 15-31: op tag to retire count */
+			tag_to_ret_ctr:16,	/* 16-31: op tag to retire count */
 			reserved1:2,		/* 32-33: reserved */
 			op_return:1,		/* 34: return op */
 			op_brn_taken:1,		/* 35: taken branch op */
-- 
2.52.0

Re: [PATCH] perf/x86/amd/ibs: Fix comment typo in ibs_op_data

Posted by Borislav Petkov 3 weeks, 4 days ago

On Tue, Jan 13, 2026 at 08:50:04PM +0800, rrrrr4413@gmail.com wrote:
> The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
> but it should be "16-31".
> 
> This just fixes the misleading comment. No functional changes.

s/This just fixes/Fix/

> Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
> ---
>  arch/x86/include/asm/amd/ibs.h       | 2 +-
>  tools/arch/x86/include/asm/amd/ibs.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

[PATCH v2] perf/x86/amd/ibs: Fix comment typo in ibs_op_data

Posted by rrrrr4413@gmail.com 3 weeks, 4 days ago

The comment for tag_to_ret_ctr in ibs_op_data says "15-31"
but it should be "16-31".

Fix the misleading comment. No functional changes.

Signed-off-by: Yen-Hsiang Hsu <rrrrr4413@gmail.com>
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
---
v1 -> v2
I took Borislav's advice to fix commit message.

v1
Link: https://lore.kernel.org/lkml/20260113125004.3173384-1-rrrrr4413@gmail.com/

 arch/x86/include/asm/amd/ibs.h       | 2 +-
 tools/arch/x86/include/asm/amd/ibs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/amd/ibs.h b/arch/x86/include/asm/amd/ibs.h
index 3ee5903982c2..7d44881d1a28 100644
--- a/arch/x86/include/asm/amd/ibs.h
+++ b/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
 	__u64 val;
 	struct {
 		__u64	comp_to_ret_ctr:16,	/* 0-15: op completion to retire count */
-			tag_to_ret_ctr:16,	/* 15-31: op tag to retire count */
+			tag_to_ret_ctr:16,	/* 16-31: op tag to retire count */
 			reserved1:2,		/* 32-33: reserved */
 			op_return:1,		/* 34: return op */
 			op_brn_taken:1,		/* 35: taken branch op */
diff --git a/tools/arch/x86/include/asm/amd/ibs.h b/tools/arch/x86/include/asm/amd/ibs.h
index cbce54fec7b9..25c00000f698 100644
--- a/tools/arch/x86/include/asm/amd/ibs.h
+++ b/tools/arch/x86/include/asm/amd/ibs.h
@@ -77,7 +77,7 @@ union ibs_op_data {
 	__u64 val;
 	struct {
 		__u64	comp_to_ret_ctr:16,	/* 0-15: op completion to retire count */
-			tag_to_ret_ctr:16,	/* 15-31: op tag to retire count */
+			tag_to_ret_ctr:16,	/* 16-31: op tag to retire count */
 			reserved1:2,		/* 32-33: reserved */
 			op_return:1,		/* 34: return op */
 			op_brn_taken:1,		/* 35: taken branch op */
-- 
2.52.0

Re: [PATCH v2] perf/x86/amd/ibs: Fix comment typo in ibs_op_data

Posted by Yen-Hsiang Hsu 2 days, 12 hours ago

Hi boris,

Gentle ping.
Let me know if you need any changes.

Thanks.