thermal: intel: Use sysfs_emit in sysfs show functions

[PATCH] thermal: intel: Use sysfs_emit in sysfs show functions

Posted by Thorsten Blum 3 weeks, 4 days ago

Replace sprintf() with sysfs_emit() in sysfs show functions.
sysfs_emit() is preferred to format sysfs output as it provides better
bounds checking.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/thermal/intel/therm_throt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/intel/therm_throt.c b/drivers/thermal/intel/therm_throt.c
index debc94e2dc16..44fa4dd15dd1 100644
--- a/drivers/thermal/intel/therm_throt.c
+++ b/drivers/thermal/intel/therm_throt.c
@@ -23,6 +23,7 @@
 #include <linux/types.h>
 #include <linux/init.h>
 #include <linux/smp.h>
+#include <linux/sysfs.h>
 #include <linux/cpu.h>
 
 #include <asm/processor.h>
@@ -144,8 +145,8 @@ static ssize_t therm_throt_device_show_##event##_##name(		\
 									\
 	preempt_disable();	/* CPU hotplug */			\
 	if (cpu_online(cpu)) {						\
-		ret = sprintf(buf, "%lu\n",				\
-			      per_cpu(thermal_state, cpu).event.name);	\
+		ret = sysfs_emit(buf, "%lu\n",				\
+			per_cpu(thermal_state, cpu).event.name);	\
 	} else								\
 		ret = 0;						\
 	preempt_enable();						\
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4

Re: [PATCH] thermal: intel: Use sysfs_emit in sysfs show functions

Posted by Rafael J. Wysocki 3 weeks, 1 day ago

On Tue, Jan 13, 2026 at 9:22 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Replace sprintf() with sysfs_emit() in sysfs show functions.
> sysfs_emit() is preferred to format sysfs output as it provides better
> bounds checking.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/thermal/intel/therm_throt.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/therm_throt.c b/drivers/thermal/intel/therm_throt.c
> index debc94e2dc16..44fa4dd15dd1 100644
> --- a/drivers/thermal/intel/therm_throt.c
> +++ b/drivers/thermal/intel/therm_throt.c
> @@ -23,6 +23,7 @@
>  #include <linux/types.h>
>  #include <linux/init.h>
>  #include <linux/smp.h>
> +#include <linux/sysfs.h>
>  #include <linux/cpu.h>
>
>  #include <asm/processor.h>
> @@ -144,8 +145,8 @@ static ssize_t therm_throt_device_show_##event##_##name(            \
>                                                                         \
>         preempt_disable();      /* CPU hotplug */                       \
>         if (cpu_online(cpu)) {                                          \
> -               ret = sprintf(buf, "%lu\n",                             \
> -                             per_cpu(thermal_state, cpu).event.name);  \
> +               ret = sysfs_emit(buf, "%lu\n",                          \
> +                       per_cpu(thermal_state, cpu).event.name);        \
>         } else                                                          \
>                 ret = 0;                                                \
>         preempt_enable();                                               \
> --

Applied as 6.20 material, thanks!