[PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637

Siratul Islam posted 4 patches 3 weeks, 6 days ago
[PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637
Posted by Siratul Islam 3 weeks, 6 days ago
Add device tree binding for the Titanmec TM1637 7-segment display
controller.

The TM1637 is a LED drive controller with a two-wire serial interface
(CLK, DIO).

Signed-off-by: Siratul Islam <email@sirat.me>
---
 .../bindings/auxdisplay/titanmec,tm1637.yaml  | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/titanmec,tm1637.yaml

diff --git a/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1637.yaml b/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1637.yaml
new file mode 100644
index 000000000000..c39000b88676
--- /dev/null
+++ b/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1637.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/auxdisplay/titanmec,tm1637.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TM1637 7-segment LED display controller
+
+maintainers:
+  - Siratul Islam <email@sirat.me>
+
+description:
+  The TM1637 is a 7-segment LED display controller with a two-wire serial
+  interface. It can drive up to 4 digits and includes brightness control.
+
+properties:
+  compatible:
+    const: titanmec,tm1637
+
+  clk-gpios:
+    maxItems: 1
+    description: GPIO for clock line
+
+  dio-gpios:
+    maxItems: 1
+    description: GPIO for data input/output line
+
+required:
+  - compatible
+  - clk-gpios
+  - dio-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    display {
+        compatible = "titanmec,tm1637";
+        clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>;
+        dio-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>;
+    };
-- 
2.47.3
Re: [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago
On 13/01/2026 05:02, Siratul Islam wrote:
> +title: TM1637 7-segment LED display controller
> +
> +maintainers:
> +  - Siratul Islam <email@sirat.me>
> +
> +description:
> +  The TM1637 is a 7-segment LED display controller with a two-wire serial
> +  interface. It can drive up to 4 digits and includes brightness control.
> +
> +properties:
> +  compatible:
> +    const: titanmec,tm1637
> +
> +  clk-gpios:
> +    maxItems: 1
> +    description: GPIO for clock line
> +
> +  dio-gpios:
> +    maxItems: 1
> +    description: GPIO for data input/output line

So you are bitbanging in the kernel? This looks too tightly coupled to
the implementation. If this is some sort of standard interface, I would
expect following standard bus-child relationship, like i2c, spi, serial
or even 1-wire.

> +
Best regards,
Krzysztof