On Tue, Jan 13, 2026 at 11:29:29AM +0800, Wei Fang wrote:
> Currently, the workaround for FEC_QUIRK_ERR007885 has three call sites,
> so add the helper fec_txq_trigger_xmit() to make the code more concise
> and reusable.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/net/ethernet/freescale/fec_main.c | 32 ++++++++++-------------
> 1 file changed, 14 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index cfb56bf0e361..85bcca932fd2 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -508,6 +508,17 @@ fec_enet_create_page_pool(struct fec_enet_private *fep,
> return err;
> }
>
> +static void fec_txq_trigger_xmit(struct fec_enet_private *fep,
> + struct fec_enet_priv_tx_q *txq)
> +{
> + if (!(fep->quirks & FEC_QUIRK_ERR007885) ||
> + !readl(txq->bd.reg_desc_active) ||
> + !readl(txq->bd.reg_desc_active) ||
> + !readl(txq->bd.reg_desc_active) ||
> + !readl(txq->bd.reg_desc_active))
> + writel(0, txq->bd.reg_desc_active);
> +}
> +
> static struct bufdesc *
> fec_enet_txq_submit_frag_skb(struct fec_enet_priv_tx_q *txq,
> struct sk_buff *skb,
> @@ -717,12 +728,7 @@ static int fec_enet_txq_submit_skb(struct fec_enet_priv_tx_q *txq,
> txq->bd.cur = bdp;
>
> /* Trigger transmission start */
> - if (!(fep->quirks & FEC_QUIRK_ERR007885) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active))
> - writel(0, txq->bd.reg_desc_active);
> + fec_txq_trigger_xmit(fep, txq);
>
> return 0;
> }
> @@ -913,12 +919,7 @@ static int fec_enet_txq_submit_tso(struct fec_enet_priv_tx_q *txq,
> txq->bd.cur = bdp;
>
> /* Trigger transmission start */
> - if (!(fep->quirks & FEC_QUIRK_ERR007885) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active))
> - writel(0, txq->bd.reg_desc_active);
> + fec_txq_trigger_xmit(fep, txq);
>
> return 0;
>
> @@ -3935,12 +3936,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
> txq->bd.cur = bdp;
>
> /* Trigger transmission start */
> - if (!(fep->quirks & FEC_QUIRK_ERR007885) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active) ||
> - !readl(txq->bd.reg_desc_active))
> - writel(0, txq->bd.reg_desc_active);
> + fec_txq_trigger_xmit(fep, txq);
>
> return 0;
> }
> --
> 2.34.1
>