[v3] Add Meta(Facebook) ventura2 BMC(AST2600)

[PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)

Posted by Kyle Hsieh 3 weeks, 5 days ago

Summary:
Add linux device tree entry related to Meta(Facebook) ventura2.
specific devices connected to BMC(AST2600) SoC.

Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v3:
- Add annotation for marvel 88e6393x
- Modify the gpio-line-name
- Modify the node order alphabetically
- Modify dt-bindings document for rmc instead of bmc
- Move the gpio-line-names to original node
- EDITME: use bulletpoints and terse descriptions.
- Link to v2: https://lore.kernel.org/r/20251224-ventura2_initial_dts-v2-0-f193ba5d4073@gmail.com

Changes in v2:
- Remove unused mdio
- Link to v1: https://lore.kernel.org/r/20251222-ventura2_initial_dts-v1-0-1f06166c78a3@gmail.com

---
Kyle Hsieh (2):
      dt-bindings: arm: aspeed: add Meta ventura2 board
      ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC

 .../devicetree/bindings/arm/aspeed/aspeed.yaml     |    1 +
 arch/arm/boot/dts/aspeed/Makefile                  |    1 +
 .../dts/aspeed/aspeed-bmc-facebook-ventura2.dts    | 2874 ++++++++++++++++++++
 3 files changed, 2876 insertions(+)
---
base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578
change-id: 20251222-ventura2_initial_dts-909b3277d665

Best regards,
-- 
Kyle Hsieh <kylehsieh1995@gmail.com>

Re: [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)

Posted by Krzysztof Kozlowski 3 weeks, 5 days ago

On 13/01/2026 03:57, Kyle Hsieh wrote:
> Summary:
> Add linux device tree entry related to Meta(Facebook) ventura2.
> specific devices connected to BMC(AST2600) SoC.
> 
> Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Where? How is this possible?

Best regards,
Krzysztof

Re: [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)

Posted by Andrew Jeffery 3 weeks, 3 days ago

On Tue, 2026-01-13 at 08:17 +0100, Krzysztof Kozlowski wrote:
> On 13/01/2026 03:57, Kyle Hsieh wrote:
> > Summary:
> > Add linux device tree entry related to Meta(Facebook) ventura2.
> > specific devices connected to BMC(AST2600) SoC.
> > 
> > Signed-off-by: Kyle Hsieh <kylehsieh1995@gmail.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> Where? How is this possible?

Kyle: Tags only apply to the patches they were provided for. Tacking
this one on the cover letter implies Krzysztof has acked the devicetree
as well, which is not the case with respect to [1].

[1]: https://lore.kernel.org/all/20251223-ginger-worm-of-swiftness-a8fa05@quoll/

It appears you're already using b4. b4 also handles tags for you:

https://b4.docs.kernel.org/en/latest/contributor/trailers.html

As it suggests, run `b4 trailers -u` to automatically and correctly
apply tags you have received for your changes.

Please fix the issue here (remove the tag from the cover-letter, apply
tags to the correct patches) and send again, _after_ you've addressed
all further feedback on v3.

Andrew