nfsd/sunrpc: fix up some layering violations

[PATCH 0/2] nfsd/sunrpc: fix up some layering violations

Posted by Jeff Layton 3 weeks, 4 days ago

The rq_lease_breaker and rq_cachetype fields are only used by nfsd.
These patches shrink struct svc_rqst slightly and makes the layering
between the two a little cleaner. In the case of rq_lease_breaker, I
think this also gives us a little more type safety.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (2):
      nfsd/sunrpc: add svc_rqst->rq_private pointer and remove rq_lease_breaker
      nfsd/sunrpc: move rq_cachetype into struct nfsd_thread_local_info

 fs/nfsd/nfs4proc.c         | 3 ++-
 fs/nfsd/nfs4state.c        | 9 ++++++---
 fs/nfsd/nfs4xdr.c          | 3 ++-
 fs/nfsd/nfscache.c         | 3 ++-
 fs/nfsd/nfsd.h             | 5 +++++
 fs/nfsd/nfssvc.c           | 8 ++++++--
 include/linux/sunrpc/svc.h | 6 ++++--
 7 files changed, 27 insertions(+), 10 deletions(-)
---
base-commit: e42954bff52b9538de21267c1bde2567b13b6632
change-id: 20260113-rq_private-05f22aac0c20

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/2] nfsd/sunrpc: fix up some layering violations

Posted by Chuck Lever 3 weeks, 3 days ago

From: Chuck Lever <chuck.lever@oracle.com>

On Tue, 13 Jan 2026 13:37:38 -0500, Jeff Layton wrote:
> The rq_lease_breaker and rq_cachetype fields are only used by nfsd.
> These patches shrink struct svc_rqst slightly and makes the layering
> between the two a little cleaner. In the case of rq_lease_breaker, I
> think this also gives us a little more type safety.
> 
> 

Applied to nfsd-testing, thanks!

[1/2] nfsd/sunrpc: add svc_rqst->rq_private pointer and remove rq_lease_breaker
      commit: 2f9a5cd51d92cd95270edfa45c11ddfce1f8e169
[2/2] nfsd/sunrpc: move rq_cachetype into struct nfsd_thread_local_info
      commit: a5428a9e04ffc2b7907cd976202d9fc28c7455f1

--
Chuck Lever

Re: [PATCH 0/2] nfsd/sunrpc: fix up some layering violations

Posted by Benjamin Coddington 3 weeks, 4 days ago

On 13 Jan 2026, at 13:37, Jeff Layton wrote:

> The rq_lease_breaker and rq_cachetype fields are only used by nfsd.
> These patches shrink struct svc_rqst slightly and makes the layering
> between the two a little cleaner. In the case of rq_lease_breaker, I
> think this also gives us a little more type safety.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Jeff Layton (2):
>       nfsd/sunrpc: add svc_rqst->rq_private pointer and remove rq_lease_breaker
>       nfsd/sunrpc: move rq_cachetype into struct nfsd_thread_local_info
>
>  fs/nfsd/nfs4proc.c         | 3 ++-
>  fs/nfsd/nfs4state.c        | 9 ++++++---
>  fs/nfsd/nfs4xdr.c          | 3 ++-
>  fs/nfsd/nfscache.c         | 3 ++-
>  fs/nfsd/nfsd.h             | 5 +++++
>  fs/nfsd/nfssvc.c           | 8 ++++++--
>  include/linux/sunrpc/svc.h | 6 ++++--
>  7 files changed, 27 insertions(+), 10 deletions(-)
> ---
> base-commit: e42954bff52b9538de21267c1bde2567b13b6632
> change-id: 20260113-rq_private-05f22aac0c20
>
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>

Both look good to me:

Reviewed-by: Benjamin Coddington <bcodding@hammerspace.com>

Ben