[PATCH 0/6] drm/imagination: Introduce hardware support check

Matt Coster posted 6 patches 3 weeks, 4 days ago
drivers/gpu/drm/imagination/Kconfig        |  12 ++
drivers/gpu/drm/imagination/Makefile       |   3 +-
drivers/gpu/drm/imagination/pvr_debugfs.c  |   2 -
drivers/gpu/drm/imagination/pvr_device.c   | 200 ++++++++++++++++++++++++++---
drivers/gpu/drm/imagination/pvr_device.h   |  24 ++--
drivers/gpu/drm/imagination/pvr_fw_trace.c | 125 +++++++++++++++---
drivers/gpu/drm/imagination/pvr_fw_trace.h |   3 -
drivers/gpu/drm/imagination/pvr_params.c   | 147 ---------------------
drivers/gpu/drm/imagination/pvr_params.h   |  72 -----------
drivers/gpu/drm/imagination/pvr_test.c     |  73 +++++++++++
10 files changed, 389 insertions(+), 272 deletions(-)
[PATCH 0/6] drm/imagination: Introduce hardware support check
Posted by Matt Coster 3 weeks, 4 days ago
We're seeing an influx of contributions to add support for lots of
different hardware containing Imagination GPUs, and for that we're
incredibly grateful.

Out of an abundance of caution, let's mark anything with intial support
that isn't yet reasonably widely tested as "experimental".

This serves two goals:
 - Don't accidentally declare that hardware with early support is usable
   without sufficient testing.
 - Allow for future breaking changes that would normally not be allowed
   (limited to this experimental hardware).

Here's a quick breakdown of the series:
 - P1-3: General cleanup & other parameter/debugfs-related enhancements.
 - P4: Introduce a module parameter to override the detected gpuid,
       which is useful for testing.
 - P5: Add KUnit infrastructure to the driver for the first time, to
       validate the error-prone task of parsing a gpuid from a string.
 - P6: Introduce the titular check.

Many of the earlier changes could go in on their own, but are not
critical fixes and would all land in the -next tree anyway so it seems
pointless to separate them from the context of the later changes.

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
---
Alexandru Dadu (1):
      drm/imagination: Add gpuid module parameter

Matt Coster (5):
      drm/imagination: Simplify module parameters
      drm/imagination: Validate fw trace group_mask
      drm/imagination: Load FW trace config at init
      drm/imagination: KUnit test for pvr_gpuid_decode_string()
      drm/imagination: Warn or error on unsupported hardware

 drivers/gpu/drm/imagination/Kconfig        |  12 ++
 drivers/gpu/drm/imagination/Makefile       |   3 +-
 drivers/gpu/drm/imagination/pvr_debugfs.c  |   2 -
 drivers/gpu/drm/imagination/pvr_device.c   | 200 ++++++++++++++++++++++++++---
 drivers/gpu/drm/imagination/pvr_device.h   |  24 ++--
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 125 +++++++++++++++---
 drivers/gpu/drm/imagination/pvr_fw_trace.h |   3 -
 drivers/gpu/drm/imagination/pvr_params.c   | 147 ---------------------
 drivers/gpu/drm/imagination/pvr_params.h   |  72 -----------
 drivers/gpu/drm/imagination/pvr_test.c     |  73 +++++++++++
 10 files changed, 389 insertions(+), 272 deletions(-)
---
base-commit: 4a768c544f64eaa2fc7cfa91e46f43aa4aad0c40
change-id: 20260107-device-support-info-f16d81b672d5
Re: [PATCH 0/6] drm/imagination: Introduce hardware support check
Posted by Matt Coster 2 weeks, 5 days ago
On Tue, 13 Jan 2026 10:16:38 +0000, Matt Coster wrote:
> We're seeing an influx of contributions to add support for lots of
> different hardware containing Imagination GPUs, and for that we're
> incredibly grateful.
> 
> Out of an abundance of caution, let's mark anything with intial support
> that isn't yet reasonably widely tested as "experimental".
> 
> [...]

Applied, thanks!

[1/6] drm/imagination: Simplify module parameters
      commit: a331631496a0af9a6f4e7e1860983afd8b1bb013
[2/6] drm/imagination: Validate fw trace group_mask
      commit: c6978643ea1c74c913f925c08ef9bafbdc031a04
[3/6] drm/imagination: Load FW trace config at init
      commit: ee184ab0ffb6cdd20527aa3b3729b824f52d3cd7
[4/6] drm/imagination: Add gpuid module parameter
      commit: 3bf74137340a1ced1566f4f9e9c2f08cba7bdf7c
[5/6] drm/imagination: KUnit test for pvr_gpuid_decode_string()
      commit: 3519e9ea13b49e7b37a20fa3a11a9e1fc5441af5
[6/6] drm/imagination: Warn or error on unsupported hardware
      commit: 1c21f240fbc1e47b94e68abfa2da2c01ed29a74d

Best regards,
-- 
Matt Coster <matt.coster@imgtec.com>
Re: [PATCH 0/6] drm/imagination: Introduce hardware support check
Posted by Alessio Belle 3 weeks, 1 day ago
On Tue, 2026-01-13 at 10:16 +0000, Matt Coster wrote:
> We're seeing an influx of contributions to add support for lots of
> different hardware containing Imagination GPUs, and for that we're
> incredibly grateful.
> 
> Out of an abundance of caution, let's mark anything with intial support
> that isn't yet reasonably widely tested as "experimental".
> 
> This serves two goals:
>  - Don't accidentally declare that hardware with early support is usable
>    without sufficient testing.
>  - Allow for future breaking changes that would normally not be allowed
>    (limited to this experimental hardware).
> 
> Here's a quick breakdown of the series:
>  - P1-3: General cleanup & other parameter/debugfs-related enhancements.
>  - P4: Introduce a module parameter to override the detected gpuid,
>        which is useful for testing.
>  - P5: Add KUnit infrastructure to the driver for the first time, to
>        validate the error-prone task of parsing a gpuid from a string.
>  - P6: Introduce the titular check.
> 
> Many of the earlier changes could go in on their own, but are not
> critical fixes and would all land in the -next tree anyway so it seems
> pointless to separate them from the context of the later changes.
> 
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> ---
> Alexandru Dadu (1):
>       drm/imagination: Add gpuid module parameter
> 
> Matt Coster (5):
>       drm/imagination: Simplify module parameters
>       drm/imagination: Validate fw trace group_mask
>       drm/imagination: Load FW trace config at init
>       drm/imagination: KUnit test for pvr_gpuid_decode_string()
>       drm/imagination: Warn or error on unsupported hardware
> 
>  drivers/gpu/drm/imagination/Kconfig        |  12 ++
>  drivers/gpu/drm/imagination/Makefile       |   3 +-
>  drivers/gpu/drm/imagination/pvr_debugfs.c  |   2 -
>  drivers/gpu/drm/imagination/pvr_device.c   | 200 ++++++++++++++++++++++++++---
>  drivers/gpu/drm/imagination/pvr_device.h   |  24 ++--
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 125 +++++++++++++++---
>  drivers/gpu/drm/imagination/pvr_fw_trace.h |   3 -
>  drivers/gpu/drm/imagination/pvr_params.c   | 147 ---------------------
>  drivers/gpu/drm/imagination/pvr_params.h   |  72 -----------
>  drivers/gpu/drm/imagination/pvr_test.c     |  73 +++++++++++
>  10 files changed, 389 insertions(+), 272 deletions(-)
> ---
> base-commit: 4a768c544f64eaa2fc7cfa91e46f43aa4aad0c40
> change-id: 20260107-device-support-info-f16d81b672d5
> 

For the whole serie,

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio