thermal: sysfs: Replace snprintf with strscpy in policy_store

[PATCH] thermal: sysfs: Replace snprintf with strscpy in policy_store

Posted by Thorsten Blum 3 weeks, 4 days ago

There is no need to use snprintf with a format specifier to copy 'buf'
to 'name'; use strscpy() directly instead.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/thermal/thermal_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index d80612506a33..e9580ddf4882 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -199,7 +199,7 @@ policy_store(struct device *dev, struct device_attribute *attr,
 	char name[THERMAL_NAME_LENGTH];
 	int ret;
 
-	snprintf(name, sizeof(name), "%s", buf);
+	strscpy(name, buf);
 
 	ret = thermal_zone_device_set_policy(tz, name);
 	if (!ret)
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4

Re: [PATCH] thermal: sysfs: Replace snprintf with strscpy in policy_store

Posted by Rafael J. Wysocki 3 weeks, 1 day ago

On Mon, Jan 12, 2026 at 6:49 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> There is no need to use snprintf with a format specifier to copy 'buf'
> to 'name'; use strscpy() directly instead.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/thermal/thermal_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
> index d80612506a33..e9580ddf4882 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -199,7 +199,7 @@ policy_store(struct device *dev, struct device_attribute *attr,
>         char name[THERMAL_NAME_LENGTH];
>         int ret;
>
> -       snprintf(name, sizeof(name), "%s", buf);
> +       strscpy(name, buf);
>
>         ret = thermal_zone_device_set_policy(tz, name);
>         if (!ret)
> --

Applied as 6.20 material, thanks!