[PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line issues in HalHWImg8723B_BB.c

Mahad Ibrahim posted 10 patches 3 weeks, 4 days ago
[PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line issues in HalHWImg8723B_BB.c
Posted by Mahad Ibrahim 3 weeks, 4 days ago
Fix checkpatch.pl checks regarding:
- Fix line ending in '('
- Remove multiple blank lines

Remove parenthesis and blank line issues to adhere to the kernel coding
standards.

Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
---
 drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
index 5fcb9420fb3d..988636a16112 100644
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
@@ -8,9 +8,7 @@
 #include <linux/kernel.h>
 #include "odm_precomp.h"
 
-static bool CheckPositive(
-	struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2
-)
+static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2)
 {
 	u8 _BoardType =
 		((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /*  _GLNA */
@@ -33,7 +31,6 @@ static bool CheckPositive(
 		pDM_Odm->TypeALNA << 16 |
 		pDM_Odm->TypeAPA << 24;
 
-
 	/*  Value Defined Check =============== */
 	/* QFN Type [15:12] and Cut Version [27:24] need to do value check */
 
-- 
2.47.3
Re: [PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line issues in HalHWImg8723B_BB.c
Posted by Greg KH 3 weeks ago
On Mon, Jan 12, 2026 at 10:42:23PM +0500, Mahad Ibrahim wrote:
> Fix checkpatch.pl checks regarding:
> - Fix line ending in '('
> - Remove multiple blank lines

That's 2 different things.  Sorry for being pedantic, but staging is
where people learn how to do this type of thing, please break this up
into multiple patches.

Note, you can do the same type of transformation on multiple files at
the same time, so maybe this series can be redone that way?

thanks,

greg k-h
Re: [PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line issues in HalHWImg8723B_BB.c
Posted by Mahad Ibrahim 2 weeks, 6 days ago
Thank you so much for the feedback and guidance.

I understand my mistake. I committed different logical
changes, no matter how small, in one commit. I will
restructure the v2 series to apply only one logical change
 across the entire driver per patch as you suggested.

I will send the v2 series shortly.

Thanks,

Mahad Ibrahim